Skip to content

Use Microsoft.AspNetCore.InternalTesting.csproj for _GetPackageVersionInfo #53152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wtgodbe merged 5 commits into from
Jan 5, 2024
Merged

Use Microsoft.AspNetCore.InternalTesting.csproj for _GetPackageVersionInfo #53152

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0ce78a2
Fix return value in _GetPackageVersionInfo
wtgodbe Jan 4, 2024
5eb85b5
Update Publishing.props
wtgodbe Jan 4, 2024
7e70c04
Update Npm.Workspace.nodeproj
wtgodbe Jan 4, 2024
f056695
Update Publishing.props
wtgodbe Jan 4, 2024
4ed2c8f
Update Publishing.props
wtgodbe Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/Npm.Workspace.nodeproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@
<Message Text="Computed package version info: %(_NodePackageNameAndVersions.PackageName)=%(_NodePackageNameAndVersions.PackageVersion)" Importance="high" />
-->
<ItemGroup>
<_NodePackageNameAndVersions>
<_ResolvedPackageVersionInfo>
<PackageVersion>$(PackageVersion)</PackageVersion>
</_NodePackageNameAndVersions>
</_ResolvedPackageVersionInfo>
Copy link
Member

@javiercn javiercn Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect, isn't it?
https://github.com/dotnet/aspnetcore/pull/53152/files#diff-87ba8ac7845060f8e3f14f5fb637b6790e56ce05e5503d2b96293301339d3910L38

returns the correct item group.

Copy link
Member

@javiercn javiercn Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other part is that this doesn't need to match <Output TaskParameter="TargetOutputs" ItemName="_ResolvedPackageVersionInfo" /> The TargetOuput here is provided in the Returns, ItemName is only where in the calling context the output needs to be placed, but they both don't have to match.

Copy link
Member Author

@wtgodbe wtgodbe Jan 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, then we must just not be setting PackageVersion in the node project anymore. There's no strong reason to use that project as far as I know, I'll try using dotnet-user-jwts.

</ItemGroup>
</Target>

Expand Down