Fix casing of ProblemDetails for RFC compliance #53789
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
requested review from
a team,
BrennanConroy and
halter73
as code owners
ghost
added
the
area-mvc
halter73
approved these changes
Feb 2, 2024
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/7761663759 |
10 tasks
halter73
reviewed
Feb 2, 2024
halter73
reviewed
Feb 2, 2024
src/Http/Http.Extensions/test/ProblemDetailsDefaultWriterTest.cs
Outdated
Show resolved
Hide resolved
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspnetcore/actions/runs/7762491021 |
10 tasks
onurmicoogullari
pushed a commit
to onurmicoogullari/aspnetcore
that referenced
this pull request
Feb 14, 2024
* Fix casing of ProblemDetails for RFC compliance * Update tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #53639.
In .NET 8, we merged a PR to remove the custom converters used for
ProblemDetailsandValidationProbleemDetailsin feature of theIgnoreWhenNullattributes that were provided in the box by System.Text.Json.At the same time, we removed the pre-defined type names that existed on the properties of these types.
As it turns out, this was a bad move. The RFC for problem details is particular about property keys being all lower-case (ref) regardless of what serialization options the rest of the system might be using by default.
This means that are implementation is no longer RFC-compliant. Fixing this by bring backing the explicit type names.
I do plan on back porting to .NET 8.