-
Notifications
You must be signed in to change notification settings - Fork 10.3k
Add support for generating OpenAPI responses #55020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using BenchmarkDotNet.Attributes; | ||
using Microsoft.AspNetCore.Builder; | ||
using Microsoft.AspNetCore.Http; | ||
using Microsoft.AspNetCore.Routing; | ||
|
||
namespace Microsoft.AspNetCore.OpenApi.Microbenchmarks; | ||
|
||
/// <summary> | ||
/// The following benchmarks are used to assess the performance of the | ||
/// core OpenAPI document generation logic. The parameter under test here | ||
/// is the number of endpoints/operations that are defined in the application. | ||
/// </summary> | ||
[MemoryDiagnoser] | ||
public class GenerationBenchmarks : OpenApiDocumentServiceTestBase | ||
{ | ||
[Params(10, 100, 1000)] | ||
public int EndpointCount { get; set; } | ||
|
||
private readonly IEndpointRouteBuilder _builder = CreateBuilder(); | ||
private readonly OpenApiOptions _options = new OpenApiOptions(); | ||
private OpenApiDocumentService _documentService; | ||
|
||
[GlobalSetup(Target = nameof(GenerateDocument))] | ||
public void OperationTransformerAsDelegate_Setup() | ||
{ | ||
_builder.MapGet("/", () => { }); | ||
for (var i = 0; i <= EndpointCount; i++) | ||
{ | ||
_builder.MapGet($"/{i}", (int i) => new Todo(1, "Write benchmarks", false, DateTime.Now)); | ||
_builder.MapPost($"/{i}", (Todo todo) => Results.Ok()); | ||
_builder.MapDelete($"/{i}", (string id) => Results.NoContent()); | ||
} | ||
_documentService = CreateDocumentService(_builder, _options); | ||
} | ||
|
||
[Benchmark] | ||
public async Task GenerateDocument() | ||
{ | ||
await _documentService.GetOpenApiDocumentAsync(); | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we change that? The less MVC we reference, the better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we discussed this in the past when we originally introduced the
ProducesResponseTypeMetadata
type. I think the conclusion at the time was to create new metadata/attributes for these annotations that was shared between MVC/minimal instead of recycling the existing ones.Because this implementation needs to work for both controller-based and minimal APIs, we're not going to be able to get away with having less MVC.