Skip to content

Removing noReload argument from WebDriverExtensions.Nagivate #55143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 22, 2024

Conversation

MattyLeslie
Copy link
Contributor

@MattyLeslie MattyLeslie commented Apr 15, 2024

Removing noReload Argument from WebDriverExtensions.Navigate

Summary of Changes:
This pull request addresses the removal of the noReload argument from the WebDriverExtensions.Navigate method. The removal was initiated in #35414, but the argument persisted. This PR rectifies this by eliminating the argument and adjusting all references throughout the tests accordingly.

Description:

  1. The following actions were undertaken:
  2. Removal of the noReload argument from the WebDriverExtensions.Navigate method.
  3. Elimination of the noReload argument from ServerTestBase.Navigate.
  4. Modification of all instances where ServerTestBase.Navigate was referenced to exclude the noReload variable.

Fixes:
This resolves issue #46810 by completely removing the noReload argument and updating all previous instances where it was utilized.

@MattyLeslie MattyLeslie requested a review from a team as a code owner April 15, 2024 13:13
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-blazor Includes: Blazor, Razor Components label Apr 15, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Apr 15, 2024
@MattyLeslie MattyLeslie changed the title #46810 Removing noReload argument from WebDriverExtensions.Nagivate Apr 16, 2024
@MattyLeslie
Copy link
Contributor Author

@SteveSandersonMS May I request a review for this please. Thanks in advance.

Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent - thanks very much!

@SteveSandersonMS SteveSandersonMS merged commit 199ea73 into dotnet:main Apr 22, 2024
26 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Apr 22, 2024
@MattyLeslie MattyLeslie deleted the #46810 branch May 20, 2024 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants