Skip to content

Merge feature/openapi to main #55182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Apr 18, 2024
Merged

Merge feature/openapi to main #55182

merged 12 commits into from
Apr 18, 2024

Conversation

captainsafia
Copy link
Member

This PR merges changes in the feature/openapi branch to main. These changes have been reviewed in individual PRs targeting this branch (ref).

Note: this pull request doesn't include JSON schema generation/schema filters at the moment. That's currently in progress in this branch based on prototypes of the upcoming JSON schema generation support coming to STJ. This will come in a later PR.

captainsafia and others added 9 commits April 2, 2024 08:27
@captainsafia
Add OpenAPI feature branch to Helix pipeline
05bf9dc
@captainsafia
Remove unneeded pipeline config
b6e09bd
@captainsafia @martincostello @Rick-Anderson
Add entry-point APIs for OpenAPI support (#54789)
cd344fa 
* Add entry-point APIs for OpenAPI support

* Apply suggestions from code review

Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Rick Anderson <[email protected]>

* Update docs and pass cancellation token to WriteAsync

* Address feedback

* Remove trailing comma in slnf

* Address more feedback

* Seal OpenApiOptions

---------

Co-authored-by: Martin Costello <[email protected]>
Co-authored-by: Rick Anderson <[email protected]>
@captainsafia
Support resolving OpenApiPaths entries from document (#54847)
1c6cfeb 
* Add support for generating OpenAPI info and paths

* Address feedback

* Fix sample and options injection

* Address more feedback
@captainsafia
Support generating OpenAPI operation and associated fields (#54903)
72f4723 
* Support generating OpenAPI operation and associated fields

* Address feedback
@captainsafia
Add APIs for OpenAPI document transformers (#54935)
b341f8c 
* Add APIs for OpenAPI document transformers

* Address feedback

* Update doc comments

* Address more feedback

* Handle service lifetimes correctly in activated transformers

* Handle disposable transformers

* Benchmark on transformer count

* Fix up disposable code and improve paths perf

* Remove unused imports in SharedTypes for RDG tests

* Clean up benchmarks and TryGetCachedOperationTransformerContext
@captainsafia
Add support for generating OpenAPI parameters (#55041)
e0c652d
@captainsafia
Add support for generating OpenAPI responses (#55020)
4fe1a1f 
* Add support for generating OpenAPI responses

* Address feedback

* Address more feedback
@captainsafia
Add support for generating OpenAPI request bodies (#55040)
d82dab5
@ghost ghost added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Apr 17, 2024
@captainsafia captainsafia added area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc labels Apr 17, 2024
BrennanConroy
BrennanConroy approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@BrennanConroy BrennanConroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you aren't going to squash?

@captainsafia
Copy link
Member Author

I assume you aren't going to squash?

Unfortunately not since merge commits are prohibited on this repo.

I plan on including links to the individual PRs in the squased commit description so there's some artifact of each commit out there.

@BrennanConroy
Copy link
Member

Unfortunately not since merge commits are prohibited on this repo.

😮 since when? I vote we have an admin merge it so we don't lose commit history.

@captainsafia
Copy link
Member Author

😮 since when? I vote we have an admin merge it so we don't lose commit history.

I think we enforced this a while ago. @wtgodbe Thoughts on allowing a merge commit for this merge from a feature branch.

@captainsafia
Copy link
Member Author

Going with a squash and merge for now. I want to avoid trying anything unconventional with this PR and about 4 of the commits on this branch are not useful on their own 😅.

I'll reference the appropriate issues in the squashed commit description.

@captainsafia captainsafia merged commit 534946e into main Apr 18, 2024
23 of 26 checks passed
@captainsafia captainsafia deleted the feature/openapi branch April 18, 2024 01:04
@dotnet-policy-service dotnet-policy-service bot added this to the 9.0-preview4 milestone Apr 18, 2024
@joegoldman2 joegoldman2 mentioned this pull request Apr 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy BrennanConroy approved these changes

@halter73 halter73 Awaiting requested review from halter73 halter73 is a code owner

@brunolins16 brunolins16 Awaiting requested review from brunolins16

@wtgodbe wtgodbe Awaiting requested review from wtgodbe wtgodbe is a code owner

Assignees
No one assigned
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework area-minimal Includes minimal APIs, endpoint filters, parameter binding, request delegate generator etc area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates feature-openapi
Projects
None yet
Milestone
9.0-preview4
Development

Successfully merging this pull request may close these issues.
2 participants
@captainsafia @BrennanConroy