Fix handling for inert route parameters in MVC #58246
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
old-area-web-frameworks-do-not-use
Closed
1 task
captainsafia
added
area-mvc
captainsafia
requested review from
amcasey and
BrennanConroy
and removed request for
a team
amcasey
approved these changes
Oct 9, 2024
captainsafia
changed the title
|
/backport to release/9.0 |
|
Started backporting to release/9.0: https://github.com/dotnet/aspnetcore/actions/runs/11248158887 |
10 tasks
captainsafia
added a commit
that referenced
this pull request
Dec 31, 2024
* Fix handling for ambient route parameters * Set default type earlier
captainsafia
added a commit
that referenced
this pull request
Feb 11, 2025
* Fix handling for ambient route parameters * Set default type earlier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #58219.
This comment provides some details about what's causing this issue when users use the Asp.Versioning library in conjunction with OpenAPI support.
We'll still need to investigate why the Asp.Versioning library isn't populating
ParameterTypecorrectly but this adds a guard in our code for these scenarios.Note: I intended to backport this PR to .NET 9.