Skip to content

Fix missing bullet list items in InputDate documentation #58310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tikap
Copy link
Contributor

@tikap tikap commented Oct 9, 2024

Fix missing bullet list items in InputDate documentation

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

Add <description> element to the bullet list.

Description

The documentation for InputDate has a bullet list with missing items as seem in the following page link:
https://learn.microsoft.com/en-us/dotnet/api/microsoft.aspnetcore.components.forms.inputdate-1?view=aspnetcore-8.0

As per the <list> XML documentation comments guideline, we need to supply a <description> entry within this list element's items. Link: https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/xmldoc/recommended-tags#list

A working example can be seen here and its corresponding code.

Fixes #57357

@tikap tikap requested a review from a team as a code owner October 9, 2024 03:30
@ghost ghost added the area-blazor Includes: Blazor, Razor Components label Oct 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 9, 2024
Copy link

Commenter does not have sufficient privileges for PR 58310 in repo dotnet/aspnetcore

@tikap tikap closed this Oct 9, 2024
@tikap tikap reopened this Oct 9, 2024
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Oct 9, 2024
@tikap
Copy link
Contributor Author

tikap commented Oct 9, 2024

Closed and re-opened PR to re-run CI

@mkArtakMSFT
Copy link
Contributor

Thanks @tikap!

@mkArtakMSFT mkArtakMSFT merged commit 5926039 into dotnet:main Oct 11, 2024
28 checks passed
captainsafia pushed a commit that referenced this pull request Dec 31, 2024
captainsafia pushed a commit that referenced this pull request Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-blazor Includes: Blazor, Razor Components community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputDate Docs has a broken list
2 participants