Skip to content

Upgrade Facebook Graph API version to v22.0 #59387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 26, 2025

Conversation

NSTom
Copy link
Contributor

@NSTom NSTom commented Dec 9, 2024

Upgrade Facebook Graph API version to v22.0

Currently, ASP.NET Core uses version v14.0 of the Facebook Graph API for authentication. This version of the API is no longer supported by Facebook, and should be upgraded to v22.0.

Description

Version v14.0 of the Graph API was supported until September 17, 2024. We should be able to safely upgrade to v22.0, the latest version, since there are no documented changes to the authorization, token or user information endpoints between these versions.

While this contributes towards #4684, it does not completely fix it, since the scope of that issue is broader than just Facebook.

@ghost ghost added the area-security label Dec 9, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Dec 9, 2024
@NSTom
Copy link
Contributor Author

NSTom commented Dec 13, 2024

@microsoft-github-policy-service agree

@mkArtakMSFT
Copy link
Member

Thanks for the PR, @NSTom.
@halter73 do we have an easy way to validate the change. While @NSTom mentioned that there are no documented breaking changes, the major version change (multiple versions, actually) is somewhat risky.
Maybe, as a safety measure, we can take this into main and ship in early .NET 10 previews to get customer validation for the scenario.

@mkArtakMSFT mkArtakMSFT added area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer and removed area-security labels Dec 13, 2024
@dotnet-policy-service dotnet-policy-service bot added the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Dec 21, 2024
@NSTom
Copy link
Contributor Author

NSTom commented Jan 21, 2025

@dotnet-policy-service agree company="Funda Real Estate B.V."

@NSTom NSTom closed this Jan 27, 2025
@NSTom NSTom reopened this Jan 27, 2025
@dotnet-policy-service dotnet-policy-service bot added this to the 10.0-preview1 milestone Jan 27, 2025
@halter73
Copy link
Member

Thanks for poking this @NSTom. Is there any reason not to use v22.0 at this point?

@NSTom NSTom changed the title Upgrade Facebook Graph API version to v21.0 Upgrade Facebook Graph API version to v22.0 Jan 28, 2025
@NSTom
Copy link
Contributor Author

NSTom commented Jan 28, 2025

Thanks for poking this @NSTom. Is there any reason not to use v22.0 at this point?

After reading the release notes, not that I can tell. I have updated the PR for v22.0.

@halter73 halter73 removed the pending-ci-rerun When assigned to a PR indicates that the CI checks should be rerun label Feb 26, 2025
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@halter73 halter73 merged commit 7bcf23d into dotnet:main Feb 26, 2025
27 checks passed
@NSTom NSTom deleted the upgrade-facebook-api-version branch March 21, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-auth Includes: Authn, Authz, OAuth, OIDC, Bearer community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants