Skip to content

[WIP] Try running tests on helix #6037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 59 commits into from
Closed

[WIP] Try running tests on helix #6037

wants to merge 59 commits into from

Conversation

HaoK
Copy link
Member

@HaoK HaoK commented Dec 19, 2018

🍿 🔥 🚒 🎆

@natemcmaster
Copy link
Contributor

Looks like the Helix SDK isn't loading correctly in MSbuild.exe. It's likely this problem: https://natemcmaster.com/blog/2017/11/11/msbuild-task-with-dependencies/#binding-redirects-and-version-conflicts

@HaoK
Copy link
Member Author

HaoK commented Jan 9, 2019

First set of results are trickling in https://mc.dot.net/#/user/aspnetcore/pr~2Faspnet~2Faspnetcore/ci/20190109.34

There were some build issues with all of the functional tests when trying the exec task, so I took all of those out for now. Servers were all throwing build errors with something about duplicate metadata/attribute existing from some kind of shared source I think. I'll dig into that more once the simple tests are mostly working

I just hardcoded the test project list for now since passing them as parameters appeared to be too long since we have so many projects.

@HaoK
Copy link
Member Author

HaoK commented Jan 9, 2019

Looks like there are a lot of failures due to missing 'sln' file, I will start mass skipping those tests

Identity tests are failing due to no local db on the helix machines (same issue as EF core functionals)

@natemcmaster
Copy link
Contributor

I'm uncomfortable with how many Skip's this adds. I would be okay with making them ConditionalFact and skipping when running in Helix, but as-is, this decreases our regression coverage significantly.

@HaoK
Copy link
Member Author

HaoK commented Jan 11, 2019

Yeah I'm just skipping them in this PR for now so its easier for me to see what tests are failing that still need to be investigated.

@natemcmaster
Copy link
Contributor

Oh, ok nvm. That's fine. We can fixup when this gets closer to merging.

@HaoK
Copy link
Member Author

HaoK commented Jan 11, 2019

Yeah there are a lot of failures and this isn't even running the functional tests yet, the vast majority seem to be looking for a sln file at least, hopefully there can be a general fix for that pattern.

I'm just trying to do an initial pass to see what tests are fine, and I'll for now stop running them and just focus on the tests with issues first.

@Eilon Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 25, 2019
@HaoK
Copy link
Member Author

HaoK commented Jan 29, 2019

Replaced by #6728

@HaoK HaoK closed this Jan 29, 2019
@HaoK HaoK deleted the haok/helix branch March 12, 2019 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants