Allow same type names in different namespaces in validator generator #62050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timdeschryver
requested review from
BrennanConroy,
halter73 and
captainsafia
as code owners
github-actions
bot
added
the
area-minimal
dotnet-policy-service
bot
added
the
community-contribution
captainsafia
approved these changes
May 21, 2025
|
|
||
| namespace Microsoft.AspNetCore.Http.ValidationsGenerator; | ||
|
|
||
| public sealed partial class ValidationsGenerator : IIncrementalGenerator | ||
| { | ||
| public static string GeneratedCodeConstructor => $@"global::System.CodeDom.Compiler.GeneratedCodeAttribute(""{typeof(ValidationsGenerator).Assembly.FullName}"", ""{typeof(ValidationsGenerator).Assembly.GetName().Version}"")"; | ||
| public static string GeneratedCodeAttribute => $"[{GeneratedCodeConstructor}]"; | ||
| private static readonly Regex InvalidNameCharsRegex = new("[^0-9A-Za-z_]", RegexOptions.Compiled); |
There was a problem hiding this comment.
Love that we can get rid of this now! 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow same type names in different namespaces in validator generator
This PR inlines the validatable type information to prevent name collisions when e.g. a same name type is used in different namespaces.
Description
CreateMethodsgenerationCreateMethods with adding the type information directly inTryGetValidatableTypeInfo`. We could also generate unique names by including the namespace, but this won't work for system types (e.g. collections or dictionaries)Fixes #61971