Skip to content

Update Google Auth UserInfo endpoint #6338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 14, 2019
Merged

Update Google Auth UserInfo endpoint #6338

merged 2 commits into from
Jan 14, 2019

Conversation

Tratcher
Copy link
Member

@Tratcher Tratcher commented Jan 3, 2019 •
edited
Loading

#6069 for 2.1. The same change can be used for 2.2 and 3.0.

Description

Google is shutting down Google+ APIs that we were using for authentication. We need to move to a new API ASAP.

Customer Impact

Without this change web applications will no longer be able to log users in with Google accounts starting as soon as Jan 28th.

Regression?

Yes, by Google.

Risk

Moderate, the new APIs use a different data format and users may get subtly different results.

@Tratcher Tratcher self-assigned this Jan 3, 2019
@Tratcher Tratcher requested a review from HaoK January 3, 2019 18:30
@Tratcher
Copy link
Member Author

Tratcher commented Jan 3, 2019

@natemcmaster I assume the branches aren't open yet for Feb?

@natemcmaster
Copy link
Contributor

Can you fill out the shiproom template? Shiproom meets at 11.

https://microsoft.sharepoint.com/teams/netfx/CLR/ProjectK/_layouts/OneNote.aspx?id=%2Fteams%2Fnetfx%2FCLR%2FProjectK%2FDocuments%2FTactics%2FNET%20Core%20Release%2Fnet-core-release&wd=target%28net-core-release.one%7C0CF34A20-F342-FA43-8944-18B555589A6B%2FShiproom%20Info%20and%20Templates%7C30A2770F-73EF-A74D-9C01-0D0B4BEAC431%2F%29

@Tratcher Tratcher mentioned this pull request Jan 3, 2019
Closed
@natemcmaster natemcmaster requested a review from Eilon January 3, 2019 18:36
@natemcmaster
Copy link
Contributor

@Eilon since @muratg is oof, are you going to rep for this in shiproom?

@natemcmaster natemcmaster added the Servicing-consider Shiproom approval is required for the issue label Jan 3, 2019
@natemcmaster natemcmaster added this to the 2.1.x milestone Jan 3, 2019
@Eilon
Copy link
Contributor

Eilon commented Jan 3, 2019

Yes I will.

@natemcmaster
Copy link
Contributor

natemcmaster commented Jan 3, 2019 •
edited
Loading

Please wait until the release/2.1 branch has been updated to build for 2.1.8. I'll add my approval when that is done. cref https://github.com/aspnet/AspNetCore-Internal/issues/1610

@Tratcher
Copy link
Member Author

Tratcher commented Jan 3, 2019

Offline notes: Add a quirk to revert to the prior behavior.

Eilon
Eilon suggested changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Un-signing off

@Tratcher Tratcher force-pushed the tratcher/2.1/google branch from f7b5afd to b86f4df Compare January 3, 2019 20:01
@Tratcher
Copy link
Member Author

Tratcher commented Jan 3, 2019

Updated with the quirks switch AppContext.SetSwitch("Switch.Microsoft.AspNetCore.Authentication.Google.UsePlus", true);

@Tratcher Tratcher mentioned this pull request Jan 3, 2019
Merged
Eilon
Eilon approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-approve this.

@gilm0079 gilm0079 mentioned this pull request Jan 8, 2019
Closed
muratg
muratg reviewed Jan 8, 2019
View reviewed changes
Copy link
Contributor

@muratg muratg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for the shiproom: 2.2.x change will be identical to this, and it'll be a merge-PR.

@jamshedd jamshedd added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Jan 8, 2019
@natemcmaster
Copy link
Contributor

Please wait until https://github.com/aspnet/AspNetCore-Internal/issues/1610 is resolved before merging.

@natemcmaster natemcmaster modified the milestones: 2.1.x, 2.1.8 Jan 8, 2019
@jamshedd
Copy link
Member

jamshedd commented Jan 8, 2019

Approved for 2.1.8

@mikaelm12
Copy link
Contributor

You'll also need to update https://github.com/aspnet/AspNetCore/blob/release/2.1/eng/PatchConfig.props with the packages that you are patching here.

@Tratcher
Copy link
Member Author

@mikaelm12 do you want to bump the version and clear out the old packages from the list first?

@mikaelm12
Copy link
Contributor

do you want to bump the version and clear out the old packages from the list first?

Sure

@Tratcher
Copy link
Member Author

Updated, but needs to rebase.

@Tratcher Tratcher force-pushed the tratcher/2.1/google branch from 6f444a2 to 3761850 Compare January 14, 2019 17:16
@Tratcher
Copy link
Member Author

@mikaelm12 ready when you are.

@mikaelm12
Copy link
Contributor

Great. The 2.1.8 branch will be ready today.

@Tratcher Tratcher merged commit 87af0c3 into release/2.1 Jan 14, 2019
@Tratcher Tratcher deleted the tratcher/2.1/google branch January 14, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muratg muratg muratg left review comments

@Eilon Eilon Eilon approved these changes

@HaoK HaoK HaoK approved these changes

Assignees

@Tratcher Tratcher

Labels
Servicing-approved Shiproom has approved the issue
Projects
None yet
Milestone
2.1.8
Development

Successfully merging this pull request may close these issues.
7 participants
@Tratcher @natemcmaster @Eilon @jamshedd @mikaelm12 @muratg @HaoK