Prevent CNG CBC size-query stack overflow for payloads > 2 MB#65521
Closed
Prevent CNG CBC size-query stack overflow for payloads > 2 MB#65521
Conversation
Co-authored-by: halter73 <54385+halter73@users.noreply.github.com>
Co-authored-by: halter73 <54385+halter73@users.noreply.github.com>
Co-authored-by: halter73 <54385+halter73@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix overflow issue with large array encryption
Prevent CNG CBC size-query stack overflow for payloads > 2 MB
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent CNG CBC size-query stack overflow for payloads > 2 MB
Summary of the changes (Less than 80 chars)
Avoid large stackalloc in CNG CBC encrypted-size query
Description
Encrypting buffers above ~2 MB regressed into stack overflow in the CNG CBC path.
The size-query helper allocated
stackalloc byte[cbInput], so large plaintext length directly consumed thread stack.Root-cause correction
CbcAuthenticatedEncryptor.GetCbcEncryptedOutputSizeWithPadding(uint cbInput), replaced input-sized stack allocation with a single-byte dummy pointer for BCrypt size queries.cbInputlength unchanged for output-size computation; only removed stack growth proportional to payload size.Regression coverage
Encrypt_OverTwoMB_RoundTrips(Windows-conditional) to validate encrypt/decrypt roundtrip for(2 * 1024 * 1024) + 1byte payloads.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.