Throw HttpSysException with HttpInitialize status details by Copilot · Pull Request #66859 · dotnet/aspnetcore

Copilot · 2026-05-26T20:57:26Z

Throw HttpSysException with HttpInitialize status details

Surface actionable diagnostics when HttpInitialize fails during Http.Sys startup.

Description

Problem
- HttpSysListener previously threw a bare PlatformNotSupportedException when HttpApi.Supported was false, hiding native failure details.
Implementation
- Added HttpApi.HttpInitializeStatusCode to persist the native HttpInitialize return value.
- Replaced the bare throw in HttpSysListener with CreateHttpInitializeFailureException(...).
- For non-success status codes, the listener now throws HttpSysException directly (instead of wrapping it).
- Exception message includes the Win32 status code (0xXXXXXXXX).
- Preserved PlatformNotSupportedException fallback when status is ERROR_SUCCESS (no specific native error to surface).
- Removed the previously added HRESULT text and related helper logic based on feedback.
Coverage
- Added/updated focused unit tests for:
  - non-success status code => returned exception is HttpSysException with status details
  - success status code => fallback PlatformNotSupportedException without inner exception

if (!HttpApi.Supported)
{
    throw CreateHttpInitializeFailureException(HttpApi.HttpInitializeStatusCode);
}

Customer Impact

Http.Sys startup failures now provide immediate root-cause diagnostics with native error semantics (HttpSysException + status code), reducing investigation time for unsupported/failed initialization environments.

Regression?

Yes
No

[If yes, specify the version the behavior has regressed from]

Risk

High
Medium
Low

Error-path exception enrichment and exception-type refinement only; no request-processing behavior changes.

Verification

Manual (required)
Automated

Packaging changes reviewed?

Yes
No
N/A

When servicing release/2.3

Make necessary changes in eng/PatchConfig.props

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

BrennanConroy · 2026-05-26T21:10:28Z

+        }
+
+        var httpInitializeException = new Win32Exception((int)httpInitializeStatusCode);
+        return new PlatformNotSupportedException(


Maybe should throw an HttpSysException

BrennanConroy · 2026-05-26T21:10:37Z


+    internal static PlatformNotSupportedException CreateHttpInitializeFailureException(uint httpInitializeStatusCode)
+    {
+        if (httpInitializeStatusCode == ErrorCodes.ERROR_SUCCESS)


Comment here?

BrennanConroy · 2026-05-26T21:13:57Z

@copilot react to feedback

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot · 2026-05-26T21:19:48Z

@copilot react to feedback

Addressed in edcf167. I updated the exception path to use HttpSysException as the inner exception and added a clarifying comment for the success-code fallback branch, then updated the focused tests accordingly.

BrennanConroy · 2026-05-26T21:24:07Z

+        }
+
+        var httpInitializeException = new HttpSysException((int)httpInitializeStatusCode);
+        return new PlatformNotSupportedException(


Wonder if this should just throw the HttpSysException? Any reason to keep using PlatformNotSupportedException?

@copilot see above

Updated in 6b01d35: for non-success HttpInitialize status codes, HttpSysListener now throws HttpSysException directly (with status code + HRESULT in the message). The ERROR_SUCCESS branch still falls back to PlatformNotSupportedException since there is no native failure code to surface.

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

BrennanConroy · 2026-05-26T21:49:59Z

+        var hResult = CreateHResultFromWin32Error(httpInitializeStatusCode);
+        return new HttpSysException(
+            (int)httpInitializeStatusCode,
+            $"HttpInitialize failed with status code 0x{httpInitializeStatusCode:X8} (HRESULT 0x{hResult:X8}).");


@copilot I don't think the HResult part is needed

Updated in 502f04ff: removed the HRESULT text from the HttpInitialize failure message and updated the related HttpSysListenerTests assertions to only validate the status code and exception type/error code.

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot

Pull request overview

This PR improves Http.Sys startup diagnostics by preserving and surfacing the native HttpInitialize return status when HttpApi.Supported is false, so failures provide actionable error information instead of a generic PlatformNotSupportedException.

Changes:

Added HttpApi.HttpInitializeStatusCode to retain the HttpInitialize return value from HttpApi static initialization.
Updated HttpSysListener to throw a tailored exception via CreateHttpInitializeFailureException(...) when Http.Sys initialization is not supported.
Added unit tests validating exception type/contents for both success and non-success status codes.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/Servers/HttpSys/test/Tests/HttpSysListenerTests.cs	Adds unit tests for the new initialization-failure exception behavior.
src/Servers/HttpSys/src/NativeInterop/HttpApi.cs	Persists `HttpInitialize` status code for later diagnostics.
src/Servers/HttpSys/src/HttpSysListener.cs	Throws a diagnostic exception (including status code) when `HttpInitialize` support is unavailable.

+    public void CreateHttpInitializeFailureException_WithErrorCode_ReturnsHttpSysExceptionWithDetails()
+    {
+        var errorCode = ErrorCodes.ERROR_ACCESS_DENIED;
+        var exception = Assert.IsType<HttpSysException>(HttpSysListener.CreateHttpInitializeFailureException(errorCode));
+
+        Assert.Contains($"status code 0x{errorCode:X8}", exception.Message);


+        return new HttpSysException(
+            (int)httpInitializeStatusCode,
+            $"HttpInitialize failed with status code 0x{httpInitializeStatusCode:X8}.");


Initial plan

72786bb

Copilot AI assigned Copilot and BrennanConroy May 26, 2026

Copilot started work on behalf of BrennanConroy May 26, 2026 20:57 View session

Copilot AI linked an issue May 26, 2026 that may be closed by this pull request

Add HttpInitialize HRESULT to HttpSysListener exception details #66858

Open

1 task

Copilot AI and others added 2 commits May 26, 2026 21:05

Add HttpInitialize details to HttpSys unsupported exception

359c2cc

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Refine HttpSys listener exception tests

64a280f

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add HttpInitialize HRESULT to HttpSysListener exception details~~ Include HttpInitialize status/HRESULT in HttpSysListener unsupported exception May 26, 2026

Copilot finished work on behalf of BrennanConroy May 26, 2026 21:09

Copilot AI requested a review from BrennanConroy May 26, 2026 21:09

BrennanConroy reviewed May 26, 2026

View reviewed changes

github-actions Bot added the area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions label May 26, 2026

Copilot started work on behalf of BrennanConroy May 26, 2026 21:14 View session

Use HttpSysException for HttpInitialize failure details

edcf167

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot finished work on behalf of BrennanConroy May 26, 2026 21:20

Copilot AI requested a review from BrennanConroy May 26, 2026 21:20

BrennanConroy reviewed May 26, 2026

View reviewed changes

Copilot started work on behalf of BrennanConroy May 26, 2026 21:24 View session

Copilot AI and others added 2 commits May 26, 2026 21:29

Throw HttpSysException for HttpInitialize failures

fa3a04e

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Throw HttpSysException directly on HttpInitialize failure

081a2a6

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

Copilot AI changed the title ~~Include HttpInitialize status/HRESULT in HttpSysListener unsupported exception~~ Throw HttpSysException with HttpInitialize status/HRESULT details May 26, 2026

Copilot finished work on behalf of BrennanConroy May 26, 2026 21:33

Copilot AI requested a review from BrennanConroy May 26, 2026 21:34

BrennanConroy reviewed May 26, 2026

View reviewed changes

Copilot started work on behalf of BrennanConroy May 26, 2026 21:50 View session

Remove HttpInitialize HRESULT text from HttpSysException message

9426098

Co-authored-by: BrennanConroy <7574801+BrennanConroy@users.noreply.github.com>

BrennanConroy approved these changes May 26, 2026

View reviewed changes

BrennanConroy marked this pull request as ready for review May 26, 2026 21:56

BrennanConroy requested a review from halter73 as a code owner May 26, 2026 21:56

Copilot AI review requested due to automatic review settings May 26, 2026 21:56

Copilot started reviewing on behalf of BrennanConroy May 26, 2026 21:56 View session

Copilot AI changed the title ~~Throw HttpSysException with HttpInitialize status/HRESULT details~~ Throw HttpSysException with HttpInitialize status details May 26, 2026

Copilot finished work on behalf of BrennanConroy May 26, 2026 21:56

Copilot AI requested a review from BrennanConroy May 26, 2026 21:56

Copilot AI reviewed May 26, 2026

View reviewed changes

BrennanConroy mentioned this pull request May 26, 2026

Add HRESULT details to HttpSysListener initialization exception #66860

Open

4 tasks

build-analysis Bot mentioned this pull request May 27, 2026

The Operation will be canceled. The next steps may not contain expected logs. dotnet/dnceng#3008

Open

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Throw HttpSysException with HttpInitialize status details#66859

Throw HttpSysException with HttpInitialize status details#66859
Copilot wants to merge 7 commits into
mainfrom
copilot/add-httpinitialize-hresult-exception-details

Copilot AI commented May 26, 2026 •

edited

Loading

Uh oh!

BrennanConroy May 26, 2026

Uh oh!

BrennanConroy May 26, 2026

Uh oh!

BrennanConroy commented May 26, 2026

Uh oh!

Copilot AI commented May 26, 2026

Uh oh!

BrennanConroy May 26, 2026

Uh oh!

BrennanConroy May 26, 2026

Uh oh!

Copilot AI May 26, 2026

Uh oh!

BrennanConroy May 26, 2026

Uh oh!

Copilot AI May 26, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

Copilot AI commented May 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Throw HttpSysException with HttpInitialize status details

Description

Customer Impact

Regression?

Risk

Verification

Packaging changes reviewed?

When servicing release/2.3

Uh oh!

BrennanConroy May 26, 2026

Choose a reason for hiding this comment

Uh oh!

BrennanConroy May 26, 2026

Choose a reason for hiding this comment

Uh oh!

BrennanConroy commented May 26, 2026

Uh oh!

Copilot AI commented May 26, 2026

Uh oh!

BrennanConroy May 26, 2026

Choose a reason for hiding this comment

Uh oh!

BrennanConroy May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 26, 2026

Choose a reason for hiding this comment

Uh oh!

BrennanConroy May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 26, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 26, 2026 •

edited

Loading