Fix MapFallback handling in RDG#67562
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Request Delegate Generator (RDG) bug where MapFallback(pattern, ...) could ignore the provided pattern (causing multiple fallback endpoints to share the default {*path:nonfile} pattern and potentially trigger ambiguous matches) when RDG is enabled.
Changes:
- Fixes the pattern-selection logic in the RDG emitter by reusing a single
hasPatternParametercondition (and avoiding the incorrect&&behavior). - Adds a regression test ensuring
MapFallbackendpoints preserve distinct provided route patterns under RDG.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/Http/Http.Extensions/test/RequestDelegateGenerator/RequestDelegateCreationTests.cs | Adds a regression test that asserts two MapFallback calls produce two RouteEndpoints with the exact provided RoutePattern.RawText values. |
| src/Http/Http.Extensions/gen/Microsoft.AspNetCore.Http.RequestDelegateGenerator/RequestDelegateGenerator.Emitter.cs | Fixes RDG interceptor emission so MapFallback(pattern, handler) correctly passes the user-provided pattern to MapCore (and only uses the default pattern for the delegate-only overload). |
DeagleGross
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #65992
The second condition used
&&incorrectly. I'm reusing a local variable to reduce duplication as well.