Skip to content

Put Mvc.NewtonsoftJson in the right section #6842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2019
Merged

Put Mvc.NewtonsoftJson in the right section #6842

merged 1 commit into from
Jan 18, 2019

Conversation

pranavkm
Copy link
Contributor

No description provided.

@natemcmaster
Copy link
Contributor

The order you list things in doesn't matter, so I don't think this fixes it. You need to also add <IsProductPackage> to the .csproj file. We're in a weird hybrid state where you need both because we haven't finished #4246 (but we're so close...it should be done today or early next week)

@pranavkm
Copy link
Contributor Author

🆙 📅

@natemcmaster natemcmaster merged commit c04f66d into master Jan 18, 2019
@natemcmaster natemcmaster deleted the pranavkm-patch-1 branch January 18, 2019 19:03
@natemcmaster natemcmaster mentioned this pull request Jan 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemcmaster natemcmaster natemcmaster approved these changes

@mkArtakMSFT mkArtakMSFT mkArtakMSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pranavkm @natemcmaster @mkArtakMSFT