Make Visual Studio 2019 a prerequisite to building this repo #7005

natemcmaster · 2019-01-25T01:26:34Z

We're preparing to consume some changes soon which will require Visual Studio 2019 (C# 8, updated .NET Core 3 SDKs, etc.)

Changes:

Updated documentation in aspnet/AspNetCore
Updated InstallVisualStudio.ps1 scripts
Updated .sln files to require VS >= 16
Updated CI config to use agents with VS 2019 installed

natemcmaster · 2019-01-25T01:26:52Z

Marked as "wip" because we haven't validated this yet on our VSTS agent pools.

.azure/pipelines/jobs/iisintegration-job.yml

natemcmaster · 2019-02-01T17:17:21Z

Blocked on https://github.com/dotnet/core-eng/issues/5029

eng/scripts/InstallVisualStudio.ps1

pakrym · 2019-02-04T18:49:43Z

We need a plan for https://github.com/aspnet/AspNetCore-Internal/issues/1764 as part of this.

natemcmaster · 2019-02-05T21:18:39Z

/AzurePipelines run AspNetCore-ci

natemcmaster · 2019-02-05T22:48:37Z

We need a plan for aspnet/AspNetCore-Internal#1764 as part of this.

Agreed. I believe the plan is to keep running tests on TeamCity until Helix comes online (wip right now -> #6728 ). I'm updating this PR to remove the ANCM build jobs for now.

I believe the core-eng team is rolling out the updated VS2019 agents today, so we should be unblocked on this now. I'd like to merge soon, so PTAL, reviewers.

natemcmaster · 2019-02-05T23:08:27Z

Build fails with an new error. I can't tell for sure, but my guess is it's a problem building the Blazor VSIX. @SteveSandersonMS @rynowak @ajaybhargavb have you seen this before?

2019-02-05T23:03:00.8270212Z Unhandled Exception: System.Runtime.Serialization.SerializationException: Unable to find assembly 'Microsoft.VisualStudio.CodeAnalysis, Version=16.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a'.
2019-02-05T23:03:00.8272220Z    at System.Runtime.Serialization.Formatters.Binary.BinaryAssemblyInfo.GetAssembly()
2019-02-05T23:03:00.8273711Z    at System.Runtime.Serialization.Formatters.Binary.ObjectReader.GetType(BinaryAssemblyInfo assemblyInfo, String name)
2019-02-05T23:03:00.8280961Z    at System.Runtime.Serialization.Formatters.Binary.ObjectMap..ctor(String objectName, String[] memberNames, BinaryTypeEnum[] binaryTypeEnumA, Object[] typeInformationA, Int32[] memberAssemIds, ObjectReader objectReader, Int32 objectId, BinaryAssemblyInfo assemblyInfo, SizedArray assemIdToAssemblyTable)
2019-02-05T23:03:00.8288479Z    at System.Runtime.Serialization.Formatters.Binary.__BinaryParser.ReadObjectWithMapTyped(BinaryObjectWithMapTyped record)

https://dev.azure.com/dnceng/public/_build/results?buildId=88221&view=logs&jobId=f31c9f97-4411-58e7-49ac-fc73f645e6b6&taskId=6eab48b9-b4ce-58d4-7c0f-2d2ef2bbc0bd&lineStart=2937&lineEnd=2943&colStart=1&colEnd=103

Damn you, PowerShell

… directory"

PR has changed significantly

natemcmaster · 2019-02-19T21:02:39Z

Resolved the git.exe problem by redirecting stderr to stdout and filtering the warning messages.

I believe this is ready for final review and ready to merge (pending CI checks, of course).

…e tasks and targets (#935) Part of dotnet/aspnetcore#7005. Resolves #881 Due to the large amount of breaking changes between MSBuild 15 and 16 (VS 2017 and VS 2019), I've decided to remove tasks broken by the upgrade instead of port them to a higher version. Changes: * Remove tasks related to dependency flow (replaced by Arcade) * Remove tasks which push and pack NuGet packages (replaced by Azure Pipelines and pack tasks in Microsoft.NET.Sdk) * Remove tasks for enabling/disabling strong name verification in .NET Framework (this was added as a workaround for bad builds from corefx which haven't happened in a long time) * Remove tasks related to running KoreBuild inside a Docker container (replaced by the `dockerbuild.sh` script in aspnet/AspNetCore`) * Remove unzip/zip tasks - there is now a version built-in to MSBuild itself which should be used instead

natemcmaster · 2019-02-19T23:17:45Z

A bunch of test failures. It looks like they fall into 3 categories:

HttpSys response caching is broken (cc @Tratcher any ideas?)
MusicStore - running dotnet publish fails, but not error is present in logs
MusicStore - some tests timeout trying to update the database

Tratcher · 2019-02-19T23:28:22Z

@natemcmaster - HttpSys - No, nothing should have changed here. The thing most likely to destabilize those tests it is changing the OS version.

natemcmaster · 2019-02-19T23:32:57Z

Yeah, that might be it. I've updated to make windows RIDs in test consistent across all projects.

natemcmaster · 2019-02-20T03:17:12Z

All required checks passed.

Eilon · 2019-02-20T06:13:32Z

eng/Workarounds.props

@@ -0,0 +1,20 @@
+<!-- Use this file to workaround issues. List the issue tracking the item to fix so we can remove the workaround when the issue is resolved. -->


Eilon

Looks a'ight to me!

Tratcher · 2019-02-20T18:42:03Z

"The version of the selected solution is higher than the solution version supported by this Visual Studio release. Please try downloading the latest service pack for this Visual Studio release, or opening in a more recent version of Visual Studio, if available."

Hosting.sln

Microsoft Visual Studio Solution File, Format Version 12.00
# Visual Studio Version 16
VisualStudioVersion = 16.0.0.0
MinimumVisualStudioVersion = 16.0.28608.199

Microsoft Visual Studio Enterprise 2019 Preview
Version 16.0.0 Preview 3.0
VisualStudio.16.Preview/16.0.0-pre.3.0+28608.199
Microsoft .NET Framework
Version 4.7.03190

Installed Version: Enterprise

natemcmaster · 2019-02-20T18:53:19Z

Hmm, setting a specific build number of VS worked in P2. I wonder if something changed in P3. I'll reset the .sln files to 16.0.0.0.

Tratcher · 2019-02-20T18:54:09Z

MinimumVisualStudioVersion = 16.0.28606.0 seems to be the highest value that works.

petke · 2019-10-07T09:21:02Z

Hi. What is the status here? I dont see any cpprestsdk.v142 nuget package.

Edit: Sorry! I seems to have commented on the wrong project here. I meant to comment on cpprestsdk. So please forget my comment.

Pilchie · 2019-10-07T14:52:38Z

@jkotalik - Can you answer @petke's question?

petke · 2019-10-07T15:00:12Z

@Pilchie. Sorry, I commented on the wrong project. So no need to answer me. Thanks

jkotalik · 2019-10-07T15:22:21Z

No worries.

…aspnetcore#7005) Changes: * Make Visual Studio 2019 a prerequisite for building this repo * Update .sln files * Update Windows SDK to 17134 * Update developer docs * Disable ANCM tests * Update to .NET Core SDK 3.0 Preview 2 * Use Microsoft.NET.Sdk.Razor as a package consistently accross the repo * React to changes in metadata from Microsoft.NETCore.App * React to changes in .NET Core SDK * Attempt to workaround CodeCheck.ps1 failure which doesn't repro locally or on different agents. Possibly due to differences in the version of the PowerShell task? * Remove dead YML file * Rename usages of win7-{x64,x86} to win-{x64,x86} * Update KoreBuild to 3.0.0-build-20190219.1 Commit migrated from dotnet/aspnetcore@85ae18c723a2

…e tasks and targets (#935) Part of dotnet/aspnetcore#7005. Resolves aspnet/BuildTools#881 Due to the large amount of breaking changes between MSBuild 15 and 16 (VS 2017 and VS 2019), I've decided to remove tasks broken by the upgrade instead of port them to a higher version. Changes: * Remove tasks related to dependency flow (replaced by Arcade) * Remove tasks which push and pack NuGet packages (replaced by Azure Pipelines and pack tasks in Microsoft.NET.Sdk) * Remove tasks for enabling/disabling strong name verification in .NET Framework (this was added as a workaround for bad builds from corefx which haven't happened in a long time) * Remove tasks related to running KoreBuild inside a Docker container (replaced by the `dockerbuild.sh` script in aspnet/AspNetCore`) * Remove unzip/zip tasks - there is now a version built-in to MSBuild itself which should be used instead

Make Visual Studio 2019 a prerequisite for building this repo

269d953

natemcmaster requested review from jkotalik, SteveSandersonMS and Tratcher as code owners January 25, 2019 01:26

natemcmaster commented Jan 25, 2019

View reviewed changes

.azure/pipelines/jobs/iisintegration-job.yml Outdated Show resolved Hide resolved

Eilon added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jan 25, 2019

natemcmaster mentioned this pull request Jan 30, 2019

Build our own packages using FrameworkReference #4257

Open

Nate McMaster added 2 commits January 31, 2019 19:24

Merge branch 'master' into vs2019

02fe688

Update .sln files

f75253c

natemcmaster added the blocked The work on this issue is blocked due to some dependency label Feb 1, 2019

Merge branch 'master' into vs2019

e29b1dd

davidfowl reviewed Feb 4, 2019

View reviewed changes

eng/scripts/InstallVisualStudio.ps1 Show resolved Hide resolved

Merge branch 'master' into vs2019

5328272

Merge branch 'master' into vs2019

e9c62cf

halter73 mentioned this pull request Feb 5, 2019

Support IAsyncEnumerable returns in SignalR hubs #6791

Merged

Nate McMaster added 2 commits February 5, 2019 14:35

Update Windows SDK to 17134

542da21

Update docs

24a8712

natemcmaster removed the blocked The work on this issue is blocked due to some dependency label Feb 5, 2019

natemcmaster changed the title ~~wip: Make Visual Studio 2019 a prerequisite to building this repo~~ Make Visual Studio 2019 a prerequisite to building this repo Feb 5, 2019

Disable ANCM tests

6499a53

Merge branch 'master' into vs2019

7f0b97e

natemcmaster mentioned this pull request Feb 5, 2019

Make VS2019 a prerequisite, and add scripts to set required env vars dotnet/extensions#1038

Merged

Capture binlog on build

6c05292

natemcmaster added the blocked The work on this issue is blocked due to some dependency label Feb 6, 2019

Nate McMaster added 3 commits February 19, 2019 12:36

Attempt to handle stderr from git better

f1c19a4

Damn you, PowerShell

Merge branch 'master' into vs2019

a0ce0b4

Exclude "The file will have its original line endings in your working…

693dc0e

… directory"

natemcmaster removed the blocked The work on this issue is blocked due to some dependency label Feb 19, 2019

Remove dead YML file

a4b929a

Rename usages of win7-{x64,x86} to win-{x64,x86}

62cd6b5

Update KoreBuild to 3.0.0-build-20190219.1

a61599f

Eilon reviewed Feb 20, 2019

View reviewed changes

Eilon approved these changes Feb 20, 2019

View reviewed changes

Nate McMaster added 2 commits February 20, 2019 07:19

Merge branch 'master' into vs2019

d3917e4

Apparently DOTNET_SKIP_FIRST_TIME_EXPERIENCE is not respected

81d3c00

dougbu approved these changes Feb 20, 2019

View reviewed changes

natemcmaster merged commit 85ae18c into dotnet:master Feb 20, 2019

natemcmaster deleted the vs2019 branch February 20, 2019 17:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Visual Studio 2019 a prerequisite to building this repo #7005

Make Visual Studio 2019 a prerequisite to building this repo #7005

natemcmaster commented Jan 25, 2019 •

edited

Loading

natemcmaster commented Jan 25, 2019

natemcmaster commented Feb 1, 2019

pakrym commented Feb 4, 2019

natemcmaster commented Feb 5, 2019

natemcmaster commented Feb 5, 2019

natemcmaster commented Feb 5, 2019

natemcmaster commented Feb 19, 2019

natemcmaster commented Feb 19, 2019

Tratcher commented Feb 19, 2019

natemcmaster commented Feb 19, 2019

natemcmaster commented Feb 20, 2019

Eilon Feb 20, 2019

Eilon left a comment

Tratcher commented Feb 20, 2019

natemcmaster commented Feb 20, 2019

Tratcher commented Feb 20, 2019

petke commented Oct 7, 2019 •

edited

Loading

Pilchie commented Oct 7, 2019

petke commented Oct 7, 2019

jkotalik commented Oct 7, 2019

		@@ -0,0 +1,20 @@
		<!-- Use this file to workaround issues. List the issue tracking the item to fix so we can remove the workaround when the issue is resolved. -->

Make Visual Studio 2019 a prerequisite to building this repo #7005

Make Visual Studio 2019 a prerequisite to building this repo #7005

Conversation

natemcmaster commented Jan 25, 2019 • edited Loading

natemcmaster commented Jan 25, 2019

natemcmaster commented Feb 1, 2019

pakrym commented Feb 4, 2019

natemcmaster commented Feb 5, 2019

natemcmaster commented Feb 5, 2019

natemcmaster commented Feb 5, 2019

natemcmaster commented Feb 19, 2019

natemcmaster commented Feb 19, 2019

Tratcher commented Feb 19, 2019

natemcmaster commented Feb 19, 2019

natemcmaster commented Feb 20, 2019

Eilon Feb 20, 2019

Choose a reason for hiding this comment

Eilon left a comment

Choose a reason for hiding this comment

Tratcher commented Feb 20, 2019

natemcmaster commented Feb 20, 2019

Tratcher commented Feb 20, 2019

petke commented Oct 7, 2019 • edited Loading

Pilchie commented Oct 7, 2019

petke commented Oct 7, 2019

jkotalik commented Oct 7, 2019

natemcmaster commented Jan 25, 2019 •

edited

Loading

petke commented Oct 7, 2019 •

edited

Loading