No-op Authorization middleware for Razor Pages #7028
Conversation
| await _next(context); | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
I guess what I expected to see was for AuthorizeFilter (MVC) to ignore AuthorizationMiddlewareInvokedKey - so that we always run authorization twice. This should be a little bit slower, but it's is close to what we shipped in preview1 that didn't have this bug.
There was a problem hiding this comment.
Summing up offline conversation: Authenticate \ Authorize has side effects and I wanted to avoid running it twice if we could help it. This does work correctly for the particular scenario that is broken. I've added an additional test with controllers to make sure that works correctly too so we've covered all the bases.
pranavkm
force-pushed
the
prkrishn/7011
branch
from
64a2ecb to
74df696
Compare
|
If this is ready to go, let's merge ASAP so we can rebuild the rest of the stack for P2. |
|
I'm confused about the contents of this PR. I can see test changes but no product code fix. |
This comment has been minimized.
This comment has been minimized.
Workaround for #7011
pranavkm
force-pushed
the
prkrishn/7011
branch
from
74df696 to
4b86197
Compare
|
🆙 📅 sorry about the confusion |
|
Merging this as flaky tests are blocking this for third round now. |
Workaround for #7011