Skip to content

Targeting pack and shared framework fixups #7794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 21, 2019
Merged

Targeting pack and shared framework fixups #7794

merged 1 commit into from
Feb 21, 2019

Conversation

natemcmaster
Copy link
Contributor

Targeting pack and shared framework fixups
6ff149e 
* Fix package type to match spec ('DotnetPlatform')
* Fix missing metadata in MSI installer
* Fix incorrect target order which caused duplicate assemblies in netcore.app and aspnetcore.app
@natemcmaster natemcmaster requested review from Eilon and pakrym February 21, 2019 16:15
Eilon
Eilon approved these changes Feb 21, 2019
View reviewed changes
Copy link
Contributor

@Eilon Eilon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small test suggestion. But otherwise go ahead and merge.

src/Framework/test/SharedFxTests.cs
.ToHashSet();

_output.WriteLine("==== actual assemblies ====");
_output.WriteLine(string.Join('\n', actualAssemblies));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious - for the sake of printing these out, would it make sense to sort them by some arbitrary string sort? That would make the debug output easier for humans to read (I realize it doesn't technically matter).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, we could order by name. I'll add that when I merge this back to master (i have green CI checks right now, and don't want to wait 90 minutes to fix this up.)

@natemcmaster natemcmaster merged commit 6252351 into release/3.0-preview3 Feb 21, 2019
@natemcmaster natemcmaster deleted the namc/sharedfx-fixup branch February 21, 2019 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eilon Eilon Eilon approved these changes

@pakrym pakrym pakrym approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@natemcmaster @Eilon @pakrym