Skip to content

Kills java instances for Azure pipelines #8568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 15, 2019
Merged

Kills java instances for Azure pipelines #8568

merged 4 commits into from
Mar 15, 2019

Conversation

javiercn
Copy link
Member

No description provided.

@javiercn javiercn requested a review from dougbu as a code owner March 15, 2019 18:42
ryanbrandenburg
ryanbrandenburg approved these changes Mar 15, 2019
View reviewed changes
dougbu
dougbu suggested changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update KillProcesses.sh too

@ryanbrandenburg ryanbrandenburg mentioned this pull request Mar 15, 2019
Closed
dougbu
dougbu approved these changes Mar 15, 2019
View reviewed changes
Copy link
Contributor

@dougbu dougbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still curious: Why is _kill java.exe or a couple of similar commands insufficient? And, why isn't it useful to kill Java processes on non-Windows machines i.e. in KillProcesses.sh (that only kills dotnet)?

@Eilon Eilon merged commit adf978a into master Mar 15, 2019
@Eilon
Copy link
Contributor

Eilon commented Mar 15, 2019

Force merged.

@Eilon
Copy link
Contributor

Eilon commented Mar 15, 2019

Thanx @javiercn !

@natemcmaster natemcmaster deleted the javiercn/kill-java-after-run-on-ci branch May 3, 2019 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eilon Eilon Eilon left review comments

@dougbu dougbu dougbu approved these changes

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@javiercn @Eilon @dougbu @ryanbrandenburg