Skip to content

Java Client Expose ConnectionId on HubConnection #8689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 29, 2019
Merged

Java Client Expose ConnectionId on HubConnection #8689

merged 2 commits into from
Mar 29, 2019

Conversation

mikaelm12
Copy link
Contributor

Part of : #8681

@mikaelm12 mikaelm12 added the area-signalr Includes: SignalR clients and servers label Mar 20, 2019
halter73
halter73 approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@halter73 halter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable. I created dotnet/AspNetCore.Docs#11687 to track adding a warning to our docs about exposing the ConnectionId publicly.

@analogrelay analogrelay added this to the 3.0.0-preview4 milestone Mar 27, 2019
@mikaelm12 mikaelm12 merged commit f10635f into master Mar 29, 2019
@natemcmaster natemcmaster deleted the mikaelm12/JavaClientConnectionId branch May 3, 2019 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@BrennanConroy BrennanConroy Awaiting requested review from BrennanConroy

Assignees

@mikaelm12 mikaelm12

Labels
area-signalr Includes: SignalR clients and servers
Projects
None yet
Milestone
3.0.0-preview4
Development

Successfully merging this pull request may close these issues.
3 participants
@mikaelm12 @halter73 @analogrelay