Skip to content

Enable single pages directory #8799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 27, 2019
Merged

Enable single pages directory #8799

merged 3 commits into from
Mar 27, 2019

Conversation

javiercn
Copy link
Member

@javiercn javiercn commented Mar 25, 2019 •
edited
Loading

Addresses #8516

@ryanbrandenburg
Copy link
Contributor

@javiercn I assume linking to the Flake-finder is a typo?

@javiercn
Copy link
Member Author

Yes

@javiercn javiercn requested review from SteveSandersonMS and removed request for ryanbrandenburg March 25, 2019 19:11
ryanbrandenburg
ryanbrandenburg approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@ryanbrandenburg ryanbrandenburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems legit.

@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label Mar 26, 2019
@javiercn javiercn force-pushed the javiercn/single-pages-directory-8515 branch from 461906e to c99a376 Compare March 26, 2019 17:36
@Tratcher Tratcher removed their request for review March 26, 2019 17:42
@javiercn
Copy link
Member Author

@SteveSandersonMS This is good to go now. I'll merge it once the build succeeds. There is currently an SDK issue that is impacting the razor components template so we should do more testing after that is fixed.

Tagging @pranavkm to follow up once that's done.

danroth27
danroth27 approved these changes Mar 26, 2019
View reviewed changes
Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@javiercn javiercn merged commit 562d119 into master Mar 27, 2019
@natemcmaster natemcmaster deleted the javiercn/single-pages-directory-8515 branch May 3, 2019 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveSandersonMS SteveSandersonMS SteveSandersonMS left review comments

@rynowak rynowak rynowak left review comments

@danroth27 danroth27 danroth27 approved these changes

@ryanbrandenburg ryanbrandenburg ryanbrandenburg approved these changes

@analogrelay analogrelay Awaiting requested review from analogrelay

@dougbu dougbu Awaiting requested review from dougbu

@halter73 halter73 Awaiting requested review from halter73

@jkotalik jkotalik Awaiting requested review from jkotalik

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@javiercn @ryanbrandenburg @SteveSandersonMS @rynowak @danroth27 @Eilon