-
Notifications
You must be signed in to change notification settings - Fork 10.3k
added beta7 coreclr sample #891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @jchannon, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! The agreement was validated by .NET Foundation and real humans are currently evaluating your PR. TTYL, DNFBOT; |
is the only diff the dockerfile? |
yup - just appended |
Then you can probably symlink all the other files. I'm no big fan of duplicating things just because we need this folder structure in docker image CI. Actually we may even rewrite the CI scripts over there to replace the image name in the dockerfile here. |
Yup makes sense. Want me to symlink to beta 7 for now? |
I'll let repo owners decide. Maintaining symlinks on Windows might be a pain :-) |
@jchannon, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
Closing because this is no longer needed. Thanks! |
…master [automated] Merge branch 'release/2.2' => 'master'
added beta7 coreclr sample 😄
ties it into the aspnet docker CI build aspnet/aspnet-docker#84