Skip to content

added beta7 coreclr sample #891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

added beta7 coreclr sample #891

wants to merge 1 commit into from

Conversation

jchannon
Copy link
Contributor

@jchannon jchannon commented Sep 5, 2015

added beta7 coreclr sample 😄

ties it into the aspnet docker CI build aspnet/aspnet-docker#84

@dnfclas
Copy link

dnfclas commented Sep 5, 2015

Hi @jchannon, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@ahmetb
Copy link

ahmetb commented Sep 9, 2015

is the only diff the dockerfile?

@jchannon
Copy link
Contributor Author

jchannon commented Sep 9, 2015

yup - just appended -coreclr

@ahmetb
Copy link

ahmetb commented Sep 9, 2015

Then you can probably symlink all the other files. I'm no big fan of duplicating things just because we need this folder structure in docker image CI.

Actually we may even rewrite the CI scripts over there to replace the image name in the dockerfile here.

@jchannon
Copy link
Contributor Author

jchannon commented Sep 9, 2015

Yup makes sense. Want me to symlink to beta 7 for now?

@ahmetb
Copy link

ahmetb commented Sep 9, 2015

I'll let repo owners decide. Maintaining symlinks on Windows might be a pain :-)

@dnfclas
Copy link

dnfclas commented Nov 18, 2016

@jchannon, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@Eilon
Copy link
Contributor

Eilon commented Nov 21, 2016

Closing because this is no longer needed. Thanks!

@Eilon Eilon closed this Nov 21, 2016
ryanbrandenburg pushed a commit that referenced this pull request Nov 26, 2018
…master

[automated] Merge branch 'release/2.2' => 'master'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants