Skip to content

Update Dockerfile calling syntax #948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2015
Merged

Update Dockerfile calling syntax #948

merged 1 commit into from
Sep 25, 2015

Conversation

glennc
Copy link
Contributor

@glennc glennc commented Sep 24, 2015

This is for #936

@anurse and @BrennanConroy Give me a shipit on the Dockerfile and general idea?

Issues with existing setup.

  • Latest sample is supposed to always run against the latest DNX, not beta7. So it needs to run against the latest unstable.
  • uname detection for clr fallback doesn't work on wheezy based Ubuntu. So I am going from Ubuntu 14.04 directly.
  • Copying project.json, restoring, then copying app would overwrite the project.lock.json with one from my build context. Which would not work because it would overwrite the lock file that was created in restore with the one from the context. This probably doesn't break people if everything lines up 100% but is not really correct.
  • Need NuGet.Config in a location that restore will use so that it gets packages from aspnetvnext instead of NuGet.org as it is running against nightly builds.

@dnfclas
Copy link

dnfclas commented Sep 24, 2015

Hi @glennc, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@glennc glennc force-pushed the glennc/updateDocker branch from 0c231f9 to f45965f Compare September 24, 2015 23:10
@analogrelay
Copy link
Contributor

Looks like a Dockerfile to me

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants