Skip to content

Added Microsoft.Extensions.Logging.EventLog to the shared framework #9865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 1, 2019
Merged

Added Microsoft.Extensions.Logging.EventLog to the shared framework #9865

merged 2 commits into from
May 1, 2019

Conversation

davidfowl
Copy link
Member

@davidfowl davidfowl requested review from dougbu and a team as code owners April 30, 2019 17:52
@Eilon Eilon requested a review from a team April 30, 2019 18:15
@Eilon Eilon added the feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform label Apr 30, 2019
natemcmaster
natemcmaster suggested changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@natemcmaster natemcmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This adds at least one new transitive dependency to our sharedfx, System.Diagnostics.EventLog.dll. You'll need to add to this section to get tests to pass

https://github.com/aspnet/AspNetCore/blob/9d5a8b3ead8cca083d182daae6b0b78c2a642ea6/eng/SharedFramework.External.props#L63-L73

@davidfowl davidfowl merged commit f08da14 into master May 1, 2019
@natemcmaster natemcmaster deleted the davidfowl/event-log branch May 1, 2019 05:36
This was referenced Oct 23, 2020
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Dec 16, 2020
Open
Open
Open
Open
Open
Open
This was referenced Feb 23, 2021
Open
Open
@Rednickle Rednickle mentioned this pull request Mar 8, 2021
Open
This was referenced Mar 8, 2021
Open
Open
This was referenced Apr 15, 2021
Open
Open
Open
Open
Open
This was referenced Apr 26, 2021
Open
Open
Open
Open
Open
Open
This was referenced May 26, 2021
Open
Open
Open
This was referenced Jun 8, 2021
Open
Open
Open
This was referenced Jun 22, 2021
Open
Open
Open
This was referenced Sep 16, 2021
Open
Open
This was referenced Oct 19, 2021
Open
Open
This was referenced Dec 30, 2021
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Mar 23, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Jul 14, 2022
Open
@rugirundao rugirundao mentioned this pull request Nov 9, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemcmaster natemcmaster natemcmaster approved these changes

@dougbu dougbu dougbu approved these changes

Assignees
No one assigned
Labels
feature-platform Deprecated: Cross-cutting issues related to ASP.NET Core as a platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@davidfowl @natemcmaster @dougbu @Eilon