Skip to content

Fix #9316 Expose Blazor HubOptions #9998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 8, 2019
Merged

Fix #9316 Expose Blazor HubOptions #9998

merged 1 commit into from
May 8, 2019

Conversation

rynowak
Copy link
Member

@rynowak rynowak commented May 6, 2019

See: #9316 (comment)

The endpoint builder part is already done.

@rynowak rynowak requested a review from SteveSandersonMS as a code owner May 6, 2019 16:00
@BrennanConroy BrennanConroy mentioned this pull request May 6, 2019
Closed
@Eilon Eilon added the area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates label May 6, 2019
@rynowak rynowak force-pushed the rynowak/signalr-hub-builder-thing branch from 62566c8 to 2e45bd2 Compare May 6, 2019 17:25
@rynowak rynowak force-pushed the rynowak/signalr-hub-builder-thing branch from 2e45bd2 to 289b01e Compare May 7, 2019 18:24
@rynowak
Copy link
Member Author

rynowak commented May 7, 2019

@SteveSandersonMS ping

@rynowak
Copy link
Member Author

rynowak commented May 7, 2019

@aspnet-hello triage https://dev.azure.com/dnceng/public/_build/results?buildId=182271&view=logs

SteveSandersonMS
SteveSandersonMS approved these changes May 8, 2019
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few questions but this looks good! I'm sure you'll make reasonable judgements about what to do with the questions, but I'm happy to discuss too if you want.

@rynowak rynowak force-pushed the rynowak/signalr-hub-builder-thing branch from 289b01e to a71dcdc Compare May 8, 2019 15:14
@rynowak rynowak merged commit b383695 into master May 8, 2019
@ghost ghost deleted the rynowak/signalr-hub-builder-thing branch May 8, 2019 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halter73 halter73 halter73 approved these changes

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

Assignees
No one assigned
Labels
area-mvc Includes: MVC, Actions and Controllers, Localization, CORS, most templates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rynowak @halter73 @SteveSandersonMS @Eilon