This repository was archived by the owner on Apr 20, 2023. It is now read-only.
Fix mcg with arg forwarding changes #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brthor
force-pushed
the
fix_mcg_arg_forwarding
branch
from
ff6ac55 to
7935a0f
Compare
brthor
force-pushed
the
fix_mcg_arg_forwarding
branch
from
7935a0f to
1e548f5
Compare
|
This was the sort of issue that I was talking about when we were going over the changes. People have to be explicitly aware of this when writing new commands. We should introduce an abstraction to handle that sooner rather than later. Also, |
TheRealPiotrP
pushed a commit
that referenced
this pull request
Jan 25, 2016
Fix mcg with arg forwarding changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Want to merge this ASAP to unblock builds in master.
cc @tijoytom @piotrpMSFT