Fix dotnet run double dash passing arguments #6313

wli3 · 2017-04-13T19:10:43Z

When run “dotnet run -- foo”, foo should be the argument passed to the
subject app. After replacing the original parser, dotnet-run did not
utilize the “unparsedtoken” of the parsed result.

There are several more issues
Due to dotnet top command are not using the new parser, the actual token
passed to the new parser at dotnet-run level are “dotnet” “run” “ --
foo” which will not give the correct result. The tokens need to be
further tokenized to be “dotnet” “run” “--” “foo”.

To append unparsedtoken to RunCommand’s argument is not straight
forward. RunCommand has an “immutable constructor”, which is a good
thing, so I made update RunCommand’s argument following the immutable
pattern -- create a new object with the original field but only change
the arguments.

livarcocc · 2017-04-13T19:16:14Z

@dotnet/dotnet-cli @jonsequitur @mikeharder

Fixes dotnet/sdk#1118

TestAssets/TestProjects/MSBuildTestEchoArgsApp/MSBuildTestApp.csproj

@@ -0,0 +1,16 @@
+<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">


src/dotnet/commands/dotnet-run/RunCommand.cs

+            Args = args;
+        }
+
+        public RunCommand MakeNewWithReplaced(string configuration = null,


src/dotnet/ParserExtensions.cs

@@ -9,6 +9,8 @@ public static class ParserExtensions
            this CommandLine.Parser parser,
            string context,
            string[] args) =>
-            parser.Parse(context.Split(' ').Concat(args).ToArray());
+            parser.Parse(context.Split(' ')
+                .Concat(args.SelectMany(a => a.Tokenize()))


When run “dotnet run -- foo”, foo should be the argument passed to the subject app. After replacing the original parser, dotnet-run did not utilize the “unparsedtoken” of the parsed result. To append unparsedtoken to RunCommand’s argument is not straight forward. RunCommand has an “immutable constructor”, which is a good thing, so I made update RunCommand’s argument following the immutable pattern -- create a new object with the original field but only change the arguments. I also made these filed private set.

ManishJayaswal · 2017-04-14T02:09:21Z

@wli3 @livarcocc please add ask mode template and then tag me for approval.

wli3 · 2017-04-14T15:53:19Z

Customer scenario

In dotnet run command
-- delimits arguments to dotnet run from arguments for the application being run. All arguments after this one are passed to the application run. For example, Run the project in the current directory (the --help argument in this example is passed to the application, since the -- argument is used):

dotnet run --configuration Release -- --help.

However, there is a regression for this feature. The arguments cannot be passed to the subject application.

Bugs this fixes

SDK #1118

Workarounds, if any

no workaround for this issue.

Risk

As the issue stated, this bug is blocking partner. It could also cause customer CI scripts disfunction.

Performance impact

Low - only few in-memory object manipulation added.

Root cause analysis

CLI start adapting new command line parser in March, 2017, the conversion for the run command failed to utilize the parse result.

No test coverage for dotnet-run double dash scenario.

How was the bug found?

manual testing

TestAssets/TestProjects/MSBuildTestApp/Program.cs

@@ -9,6 +9,10 @@ public class Program
    {
        public static void Main(string[] args)
        {
+          if (args.Length > 0)
+            {


src/dotnet/commands/dotnet-complete/ParseCommand.cs

@@ -24,6 +24,11 @@ public static int Run(string[] args)

            Console.WriteLine(result.Diagram());

+            if (result.UnparsedTokens.Any()) {


wli3 · 2017-04-14T18:01:35Z

@dotnet-bot Test Windows_NT x86 Debug Build

dnfclas added the cla-already-signed label Apr 13, 2017

livarcocc reviewed Apr 13, 2017

View reviewed changes

TestAssets/TestProjects/MSBuildTestEchoArgsApp/MSBuildTestApp.csproj Outdated

@@ -0,0 +1,16 @@

<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

This comment was marked as spam.

Sign in to view

wli3 force-pushed the fix-dotnetrun--passing-args branch from e42700d to d6c1609 Compare April 13, 2017 20:07

livarcocc reviewed Apr 13, 2017

View reviewed changes

src/dotnet/commands/dotnet-run/RunCommand.cs

Args = args;

}

public RunCommand MakeNewWithReplaced(string configuration = null,

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

wli3 force-pushed the fix-dotnetrun--passing-args branch from d6c1609 to 720de6c Compare April 13, 2017 20:47

wli3 requested review from jonsequitur, dsplaisted and johnbeisner April 13, 2017 20:54

wli3 commented Apr 13, 2017

View reviewed changes

wli3 force-pushed the fix-dotnetrun--passing-args branch from dcd5f4d to 9ae6d79 Compare April 13, 2017 23:22

wli3 force-pushed the fix-dotnetrun--passing-args branch from 9ae6d79 to 83f3a3e Compare April 13, 2017 23:57

wli3 requested a review from ManishJayaswal April 14, 2017 00:33

wli3 added the Pending Shiproom Approval label Apr 14, 2017

wli3 requested review from ManishJayaswal and removed request for ManishJayaswal April 14, 2017 00:34

ManishJayaswal added the Approved to merge label Apr 14, 2017

livarcocc reviewed Apr 14, 2017

View reviewed changes

TestAssets/TestProjects/MSBuildTestApp/Program.cs Outdated

@@ -9,6 +9,10 @@ public class Program

{

public static void Main(string[] args)

{

if (args.Length > 0)

{

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

livarcocc reviewed Apr 14, 2017

View reviewed changes

src/dotnet/commands/dotnet-complete/ParseCommand.cs Outdated

@@ -24,6 +24,11 @@ public static int Run(string[] args)

Console.WriteLine(result.Diagram());

if (result.UnparsedTokens.Any()) {

This comment was marked as spam.

Sign in to view

livarcocc approved these changes Apr 14, 2017

View reviewed changes

Fix format

def4322

wli3 force-pushed the fix-dotnetrun--passing-args branch from 90de12e to def4322 Compare April 14, 2017 17:35

wli3 merged commit d55ed34 into dotnet:master Apr 14, 2017

This was referenced Apr 19, 2017

add performance test (baseline) for text decoding (#1476) dotnet/corefxlab#1481

Closed

Poor TextEncoder.TryDecode performance (UTF8) dotnet/corefxlab#1476

Closed

wli3 deleted the fix-dotnetrun--passing-args branch March 27, 2019 19:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix dotnet run double dash passing arguments #6313

Fix dotnet run double dash passing arguments #6313

Uh oh!

wli3 commented Apr 13, 2017

Uh oh!

livarcocc commented Apr 13, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ManishJayaswal commented Apr 14, 2017

Uh oh!

wli3 commented Apr 14, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

wli3 commented Apr 14, 2017

Uh oh!

Uh oh!

		@@ -0,0 +1,16 @@
		<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">

		@@ -24,6 +24,11 @@ public static int Run(string[] args)

		Console.WriteLine(result.Diagram());

		if (result.UnparsedTokens.Any()) {

Fix dotnet run double dash passing arguments #6313

Fix dotnet run double dash passing arguments #6313

Uh oh!

Conversation

wli3 commented Apr 13, 2017

Uh oh!

livarcocc commented Apr 13, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

ManishJayaswal commented Apr 14, 2017

Uh oh!

wli3 commented Apr 14, 2017

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

This comment was marked as spam.

Uh oh!

wli3 commented Apr 14, 2017

Uh oh!

Uh oh!