Skip to content
This repository was archived by the owner on Jul 12, 2022. It is now read-only.

Fix multiline copyright header rule #76

Merged
merged 1 commit into from
Feb 27, 2015

Conversation

krwq
Copy link
Member

@krwq krwq commented Feb 23, 2015

Fix a problem where some lines of multiline header are repeated during the formatting already formmated code.

I.e:

// test1
// test2

was formatted to:

// test1
// test2

// test1
// test2

When using real headers some of those lines are removed as they are treated as "old" header. I.e:

// Copyright blah
// License X

was being formatted to:

// Copyright blah
// License X

// License blah

@krwq
Copy link
Member Author

krwq commented Feb 23, 2015

I just found an issue with that, doesn't work correctly with:

// Copyright blah
// License X

// My Comment

@krwq krwq force-pushed the FixCopyRightHeaderRule branch from 2f975f9 to b5b7e56 Compare February 23, 2015 20:54
@krwq
Copy link
Member Author

krwq commented Feb 23, 2015

Above is fixed in the updated PR.

@krwq krwq force-pushed the FixCopyRightHeaderRule branch from b5b7e56 to 6aa8070 Compare February 23, 2015 21:09
@krwq
Copy link
Member Author

krwq commented Feb 23, 2015

Above fixes the issue where there are whitespaces after the comment in the header (really rare but could happen).

@krwq
Copy link
Member Author

krwq commented Feb 25, 2015

Hi @jaredpar, could you take a look at this PR?

@jaredpar
Copy link
Member

👍

Thanks for fixing that.

krwq added a commit that referenced this pull request Feb 27, 2015
Fix multiline copyright header rule
@krwq krwq merged commit 299dd7a into dotnet:master Feb 27, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants