This repository was archived by the owner on Jul 12, 2022. It is now read-only.
Fix VB trivia handling with comments + attrs #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The explicit modifier code for VB wasn't correctly handling the leading trivia on types and methods. It mistakenly grabbed and replaced the trivia on the node instead of the appropriate keyword token when there were no other modifiers. This resulted in strange effects like comments being moved below attributes. Fixed the first modifier case to use the keyword for trivial handling instead.
jaredpar
added a commit
that referenced
this pull request
Feb 27, 2015
Fix VB trivia handling with comments + attrs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The explicit modifier code for VB wasn't correctly handling the leading
trivia on types and methods. It mistakenly grabbed and replaced the
trivia on the node instead of the appropriate keyword token when there
were no other modifiers. This resulted in strange effects like comments
being moved below attributes.
Fixed the first modifier case to use the keyword for trivial handling
instead.