This repository was archived by the owner on Jul 12, 2022. It is now read-only.
Fix a couple of newline issues #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The two HasNewLineBefore rules had a couple of small issues that needed to be addressed. 1. They were unconditionally using CRLF which could possibly lead to mixed line endings in files. The code was changed to prefer existing endings instead. 2. They were formatting around #if blocks which is suspect and needs to be disabled. 3. Produced new SyntaxNode values on trees that already had the correct formatting. This was potentially changing line endings and made it difficult to find noisy rules in the formatter. After looking at the logic of these rules they appear to really just be the same rule run against two different nodes. Hence I merged them into a single rule to make it easier to share code.
|
Merging this new because I found a more serious issue I need to fix that depends on this change. Even though I'm merging this now I will respond / update code based on any feedback left on this PR. |
jaredpar
added a commit
that referenced
this pull request
Feb 27, 2015
Fix a couple of newline issues
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two HasNewLineBefore rules had a couple of small issues that needed
to be addressed.
mixed line endings in files. The code was changed to prefer existing
endings instead.
be disabled.
formatting. This was potentially changing line endings and made it
difficult to find noisy rules in the formatter.
After looking at the logic of these rules they appear to really just be
the same rule run against two different nodes. Hence I merged them into
a single rule to make it easier to share code.