Skip to content

System.CommandLine is split into too many namespaces #1788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 1, 2022
Merged

System.CommandLine is split into too many namespaces #1788

merged 6 commits into from
Jul 1, 2022

Conversation

BenjaminMichaelis
Copy link
Contributor

@BenjaminMichaelis BenjaminMichaelis commented Jul 1, 2022 •
edited
Loading

Fixes #1680

@BenjaminMichaelis BenjaminMichaelis marked this pull request as ready for review July 1, 2022 07:20
@BenjaminMichaelis BenjaminMichaelis changed the title #1680 System.CommandLine is split into too many namespaces System.CommandLine is split into too many namespaces Jul 1, 2022
@jonsequitur
Copy link
Contributor

Thanks @BenjaminMichaelis!

There are tests failing because this project also needs to be updated: src\System.CommandLine.Suggest.Tests\EndToEndTestApp.

It's not part of the solution because it's only used for integration testing.

BenjaminMichaelis
BenjaminMichaelis commented Jul 1, 2022
View reviewed changes
@jonsequitur jonsequitur merged commit a1958c0 into dotnet:main Jul 1, 2022
@BenjaminMichaelis BenjaminMichaelis deleted the 1680-systemcommandline-is-split-into-too branch July 1, 2022 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonsequitur jonsequitur jonsequitur approved these changes

@Marusyk Marusyk Marusyk approved these changes

Assignees
No one assigned
Labels
Breaking Change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

System.CommandLine is split into too many namespaces
3 participants
@BenjaminMichaelis @jonsequitur @Marusyk