[1653] remove the legacy double dash behavior and ParseResult.UnparsedTokens #1806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonsequitur
reviewed
Aug 1, 2022
| @@ -243,7 +235,7 @@ private void ParseRemainingTokens() | |||
| } | |||
| else if (foundEndOfArguments) | |||
| { | |||
| AddCurrentTokenToUnparsed(); | |||
| AddCurrentTokenToUnmatched(); | |||
There was a problem hiding this comment.
I don't think this is the right behavior. This should probably not be doing anything special at this point. If you remove the call to AddCurrentTokenToUnmatched do all of the tests pass?
There was a problem hiding this comment.
Yeah, you are right. The whole method become useless. I removed it.
jonsequitur
approved these changes
Aug 2, 2022
|
Thanks, @Tunduk! |
|
@jonsequitur Thanks for you review! |
|
Yes we can! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue #1653