Move version option out of middleware #1969
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
reviewed
Nov 15, 2022
| @@ -38,7 +38,7 @@ public override ICommandHandler GetCommandHandler() | |||
| } | |||
| } | |||
|
|
|||
| public override ModelDescriptor Parent => ModelDescriptor.FromType(_handlerMethodInfo.ReflectedType); | |||
| public override ModelDescriptor Parent => ModelDescriptor.FromType(_handlerMethodInfo.ReflectedType!); | |||
There was a problem hiding this comment.
though not the change here. I do wonder if we should be using ReflectedType. https://learn.microsoft.com/en-us/dotnet/api/system.runtime.interopservices._methodinfo.reflectedtype?view=netframework-4.8#remarks
jonsequitur
force-pushed
the
version-option-redesign-experiment
branch
from
3d2caac to
1969612
Compare
jozkee
reviewed
Nov 17, 2022
jozkee
reviewed
Nov 17, 2022
…sign-experiment # Conflicts: # src/System.CommandLine/Builder/CommandLineBuilderExtensions.cs # src/System.CommandLine/Option.cs # src/System.CommandLine/Parsing/ParseResultVisitor.cs
adamsitnik
approved these changes
Feb 2, 2023
There was a problem hiding this comment.
LGTM! The allocations have dropped nicely!
| Method | Args | before | after |
|---|---|---|---|
| DefaultsSync | String[0] | 10,584 B | 10,264 B |
| DefaultsAsync | String[0] | 10,584 B | 10,264 B |
| MinimalSync | String[0] | 3,256 B | 3,264 B |
| MinimalAsync | String[0] | 3,256 B | 3,264 B |
| DefaultsSync | String[4] | 12,080 B | 11,760 B |
| DefaultsAsync | String[4] | 12,080 B | 11,760 B |
| MinimalSync | String[4] | 4,752 B | 4,760 B |
| MinimalAsync | String[4] | 4,752 B | 4,760 B |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.