First name and aliases cleanup #1990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move GetLongestAlias to IdentifierSymbol and re-use where possible
jozkee
reviewed
Dec 14, 2022
| var alias = identifierSymbol.Aliases.First(); | ||
| var alias = identifierSymbol.GetLongestAlias(removePrefix: false); |
There was a problem hiding this comment.
This wasn't really getting the longest alias but the first one.
There was a problem hiding this comment.
It was inconsistent. As you can see other places in the source code were using longest option alias to get its default alias. Here we were using the first one but it was a bug (at least in my opinion).
There was a problem hiding this comment.
Could this just use the name rather than an alias?
There was a problem hiding this comment.
Option.Name should not contain the prefix, while here we care about prefix.
Co-authored-by: David Cantú <[email protected]>
jozkee
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symbolwere defining it's own name field. I've removed these and now all of them are just using_namedefined bySymbolOption.HasAliasIgnoringPrefixas it's not for general purposeGetLongestAliaspart of base type and re-using it where possible_aliasesfield, as it will most likely change once we introduce the concept of a hidden alias