Skip to content

merge CommandLineStringSplitter into Parser #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 8, 2023
Merged

merge CommandLineStringSplitter into Parser #2079

merged 2 commits into from
Mar 8, 2023

Conversation

adamsitnik
Copy link
Member

Benefits:

fixes #1937

@adamsitnik adamsitnik requested review from jonsequitur and Keboo March 7, 2023 19:43
jonsequitur
jonsequitur reviewed Mar 7, 2023
View reviewed changes
src/System.CommandLine/Parsing/Parser.cs Outdated
/// </summary>
/// <param name="commandLine">A command line input string.</param>
/// <returns>A sequence of strings.</returns>
public static IEnumerable<string> Split(string commandLine)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe SplitCommandLine would be clearer?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea, done!

@adamsitnik adamsitnik merged commit 3e0d47c into dotnet:main Mar 8, 2023
@adamsitnik adamsitnik deleted the splitter branch March 8, 2023 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonsequitur jonsequitur jonsequitur approved these changes

@Keboo Keboo Awaiting requested review from Keboo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider renaming CommandLineStringSplitter
2 participants
@adamsitnik @jonsequitur