Move BindingContext and related types to NamingConventionBinder project #2093
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to remove
BindingContext
fromInvocationContext
(a step toward replacingInvocationContext
withParseResult
in command handler/action), I've moved it to NamingConventionBinder and made the handler responsible for keeping the reference toBindingContext
.Now all the
CommandHandler.Create
methods returnBindingHandler
rather thanICommandHandler
, and to get theBindingContext
the users need to callInvocationContext.GetBindingContext()
, which internaly usesctx.ParseResult.CommandResult.Command.Handler
:Of course it's not that simple, I had to add some workarounds to adjust for the fact that Hosting uses Middleware for dependency injection registration and very late command handler creation.
I know that it ain't pretty, but the only alternative I had was removing
NamingConventionBinder
project.