This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Add Array.Reverse<T> #7132
Merged
Add Array.Reverse<T> #7132
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add generic `Reverse<T>` methods to `Array`.
Implement `List<T>.Reverse` using `Array.Reverse<T>`.
| ThrowHelper.ThrowArgumentNullException(ExceptionArgument.array); | ||
| if (index < 0) | ||
| ThrowHelper.ThrowIndexArgumentOutOfRange_NeedNonNegNumException(); | ||
| if (length < 0) |
There was a problem hiding this comment.
This might increase the generated code size, but I think you can make this a teeny bit faster for the common case:
if ((index | length) < 0) // Will be true if either is negative
{
if (index < 0)
ThrowHelper.ThrowIndexArgumentOutOfRange_NeedNonNegNumException();
else
ThrowHelper.ThrowArgumentOutOfRangeException(ExceptionArgument.length, ExceptionResource.ArgumentOutOfRange_NeedNonNegNum);
}There was a problem hiding this comment.
I just aligned this with what @benaadams did for the non-generic Reverse in #7059.
|
Once this is added to the contracts, there are other places that should probably be fixed to call |
|
cc @janvorli |
|
LGTM |
|
@justinvp Could you please port it to corert when you get a chance? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Array.Reverse<T>and updateList<T>.Reverseto use it.https://github.com/dotnet/corefx/issues/2352 (api-approved)
cc: @jkotas, @stephentoub, @weshaggard, @jamesqo, @benaadams