Skip to content
This repository was archived by the owner on Jan 23, 2023. It is now read-only.

Improve span copy of pointers and structs containing pointers #9999

Merged
merged 7 commits into from
Mar 9, 2017
Merged

Improve span copy of pointers and structs containing pointers #9999

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
75cc69f
Improve span copy of pointers and structs containing pointers
Mar 7, 2017
47afec9
Address feedback
Mar 7, 2017
989ea9a
Add GC poll
Mar 8, 2017
d879bdd
Disable __m128 intrinsic usage on Unix for this PR
Mar 8, 2017
fb6ed34
Align destination before loop
Mar 9, 2017
65ef729
Enable xmm intrinsics path on Unix
Mar 9, 2017
0de3e24
Fix copy forward loop
Mar 9, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
76 changes: 9 additions & 67 deletions src/classlibnative/bcltype/arraynative.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
#include "security.h"
#include "invokeutil.h"

#include "arraynative.inl"

FCIMPL1(INT32, ArrayNative::GetRank, ArrayBase* array)
{
FCALL_CONTRACT;
Expand Down Expand Up @@ -883,85 +885,25 @@ void memmoveGCRefs(void *dest, const void *src, size_t len)
NOTHROW;
GC_NOTRIGGER;
MODE_COOPERATIVE;
PRECONDITION(CheckPointer(dest));
PRECONDITION(CheckPointer(src));
PRECONDITION(len >= 0);
SO_TOLERANT;
}
CONTRACTL_END;

_ASSERTE(dest != nullptr);
_ASSERTE(src != nullptr);

// Make sure everything is pointer aligned
_ASSERTE(IS_ALIGNED(dest, sizeof(SIZE_T)));
_ASSERTE(IS_ALIGNED(src, sizeof(SIZE_T)));
_ASSERTE(IS_ALIGNED(len, sizeof(SIZE_T)));

size_t size = len;
BYTE * dmem = (BYTE *)dest;
BYTE * smem = (BYTE *)src;

GCHeapMemoryBarrier();

if (dmem <= smem || smem + size <= dmem)
{
// copy 16 bytes at a time
while (size >= 4 * sizeof(SIZE_T))
{
size -= 4 * sizeof(SIZE_T);
((SIZE_T *)dmem)[0] = ((SIZE_T *)smem)[0];
((SIZE_T *)dmem)[1] = ((SIZE_T *)smem)[1];
((SIZE_T *)dmem)[2] = ((SIZE_T *)smem)[2];
((SIZE_T *)dmem)[3] = ((SIZE_T *)smem)[3];
smem += 4 * sizeof(SIZE_T);
dmem += 4 * sizeof(SIZE_T);
}

if ((size & (2 * sizeof(SIZE_T))) != 0)
{
((SIZE_T *)dmem)[0] = ((SIZE_T *)smem)[0];
((SIZE_T *)dmem)[1] = ((SIZE_T *)smem)[1];
smem += 2 * sizeof(SIZE_T);
dmem += 2 * sizeof(SIZE_T);
}
_ASSERTE(CheckPointer(dest));
_ASSERTE(CheckPointer(src));

if ((size & sizeof(SIZE_T)) != 0)
{
((SIZE_T *)dmem)[0] = ((SIZE_T *)smem)[0];
}
}
else
if (len != 0 && dest != src)
{
smem += size;
dmem += size;

// copy 16 bytes at a time
while (size >= 4 * sizeof(SIZE_T))
{
size -= 4 * sizeof(SIZE_T);
smem -= 4 * sizeof(SIZE_T);
dmem -= 4 * sizeof(SIZE_T);
((SIZE_T *)dmem)[3] = ((SIZE_T *)smem)[3];
((SIZE_T *)dmem)[2] = ((SIZE_T *)smem)[2];
((SIZE_T *)dmem)[1] = ((SIZE_T *)smem)[1];
((SIZE_T *)dmem)[0] = ((SIZE_T *)smem)[0];
}

if ((size & (2 * sizeof(SIZE_T))) != 0)
{
smem -= 2 * sizeof(SIZE_T);
dmem -= 2 * sizeof(SIZE_T);
((SIZE_T *)dmem)[1] = ((SIZE_T *)smem)[1];
((SIZE_T *)dmem)[0] = ((SIZE_T *)smem)[0];
}

if ((size & sizeof(SIZE_T)) != 0)
{
smem -= sizeof(SIZE_T);
dmem -= sizeof(SIZE_T);
((SIZE_T *)dmem)[0] = ((SIZE_T *)smem)[0];
}
InlinedMemmoveGCRefsHelper(dest, src, len);
}

SetCardsAfterBulkCopy((Object**)dest, len);
}

void ArrayNative::ArrayCopyNoTypeCheck(BASEARRAYREF pSrc, unsigned int srcIndex, BASEARRAYREF pDest, unsigned int destIndex, unsigned int length)
Expand Down
Loading