This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Make Queue.Peek inline #12062
Merged
Make Queue.Peek inline #12062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Sep 26, 2016
| @@ -328,6 +330,12 @@ private void MoveNext(ref int index) | |||
| index = (tmp == _array.Length) ? 0 : tmp; | |||
| } | |||
|
|
|||
| private void ThrowForEmptyQueue() | |||
There was a problem hiding this comment.
Dequeue can call this as well, right? If nothing else it'd avoid duplicate usage of InvalidOperation_EmptyQueue. Not enough of a reason to separate it out into its own function, but as long as it is being separated out, might as well do so.
There was a problem hiding this comment.
Good point, I forgot Dequeue does this as well. Have updated.
karelz
added
area-System.Collections
enhancement
|
LGTM. |
|
Test Innerloop Windows_NT Debug Build and Test |
|
Thanks. |
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Commit migrated from dotnet/corefx@2d0e2ab
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can trivially make Queue.Peek inline by moving the throw code into a new method. JIT will not inline this as per dotnet/coreclr#6103.
Test code, before/after asm
@ianhays