This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Delete bad test from AsyncValueTaskMethodBuilderTests #23356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Aug 17, 2017
stephentoub
reviewed
Aug 17, 2017
|
|
||
| await callbackCompleted.Task; | ||
| Assert.Equal(dsm, foundSm); | ||
| } |
There was a problem hiding this comment.
Looks like you'll need to delete https://github.com/adityamandaleeka/corefx/blob/ae7f6350baa5798459936a00e3b24e0e05356e92/src/System.Threading.Tasks.Extensions/tests/AsyncValueTaskMethodBuilderTests.cs#L187 as well, or else you'll get warnings-as-errors for not using that.
adityamandaleeka
force-pushed
the
delete_bad_AsyncValueTaskMethodBuilderTest
branch
from
ae7f635 to
6337ec3
Compare
|
@mellinoe, another System.Drawing tests seg fault on Linux: |
|
@adityamandaleeka could you please port this to release/uwp6.0 branch? |
adityamandaleeka
added a commit
to adityamandaleeka/corefx
that referenced
this pull request
Aug 17, 2017
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing on uapaot (https://github.com/dotnet/corefx/issues/22545). It turns out that the behavior it depends on was explicitly disabled in Release builds of S.P.CoreLib (see the issue for details).
Per @stephentoub, this test was added only to increase code coverage, and the machinery it depends on is being removed in CoreCLR soon too (dotnet/coreclr#13105). With that in mind, we feel it's pretty safe to just delete the test.
@stephentoub PTAL
Fixes https://github.com/dotnet/corefx/issues/22545