This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Don't use Array.Reverse in ImmutableArray<T>.Builder.Reverse #2354
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The non-generic Array.Reverse does not perform well for non-primitive value types.
|
LGTM. Thanks. |
stephentoub
added a commit
that referenced
this pull request
Jul 14, 2015
Don't use Array.Reverse in ImmutableArray<T>.Builder.Reverse
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
Don't use Array.Reverse in ImmutableArray<T>.Builder.Reverse Commit migrated from dotnet/corefx@77b5b79
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The non-generic
Array.Reversedoes not perform well for non-primitive value types.See the following for details:
dotnet/coreclr#1231
Note: I considered adding a common
ArrayHelpersclass, as there are some other uses ofArray.Reversein corefx. However, the other uses didn't seem to warrant the use of the improvedReverse:Array.Reverseonbyte[]which is a primitive type thatArray.Reversehas a fast-path for (example, example, etc.).Stack<T>.CopyTocallsArray.Reverseonly in a rare caseReadOnlyCollectionBuilder<T>is internal and it doesn't look likeReadOnlyCollectionBuilder.Reverseis actually used at all.