This repository was archived by the owner on Jan 23, 2023. It is now read-only.
Additional String.StartsWith tests #3478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dotnet-bot test this please |
| if (comparisionType == StringComparison.CurrentCulture) | ||
| { | ||
| Assert.Equal(expected, text.StartsWith(value)); | ||
| } |
There was a problem hiding this comment.
Why have this special case? Wouldn't be sufficient to just always do:
Assert.Equal(expected, text.StartsWith(value, comparisonType);?
There was a problem hiding this comment.
I've seen this pattern done (and done it my self) in a few places for code coverage purposes (now you get String.StartsWith(String) covered)).
Personally, I could go either way.
There was a problem hiding this comment.
Yep that was the reason. Just to get it included in the testing.
|
LGTM. Nice to see ICU passing on this as well! Thanks very much for these additions! |
|
Fixed comparisonType typo |
stephentoub
added a commit
that referenced
this pull request
Sep 27, 2015
Additional String.StartsWith tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greater coverage and StringComparision usage.
"Soft Hyphen" is ignored on all Windows cultures. I'll see from the CI build whether this is also holds true on Linux. Otherwise I might have to use a fixed culture and chars known to work.