Fix RIO Connection Receives

[KodrAus]

Rebase of #1420

Fixes an issue with RioTcpConnections not flushing receives.

cc: @davidfowl @benaadams

Changes:

• Remove the offloading of notifies, there isn't a separate thread for them anymore
• Complete receives synchronously, rather than flushing later
• Ensure the RioThread is in a valid state before from ctor
• Add a stress test for RioTcpServer

[KodrAus]

Hm, looks like release build is hanging. I'll investigate locally.

[KodrAus]

Trying out an idea to fix the build hanging. If it works, I'll clean up then ping for review.

[KodrAus]

r? @davidfowl

Build is green, but I'm not totally confident about it. I think it needs a few more runs.

[ahsonkhan]

Build is green, but I'm not totally confident about it. I think it needs a few more runs.

@KodrAus, any updates to this PR?

[KodrAus]

@ahsonkhan I can't reproduce the flakiness locally so have put a Skip on the test, which I suspect is the issue anyways.

I still think it's worth a review because the code before simply didn't work. So assuming the rest is good I guess we can either:

• Merge as-is with the Skip
• Remove the test
• Forget this code and work on porting the Kestrel transport instead

I'm happy with whatever approach.

[ahsonkhan]

I still think it's worth a review because the code before simply didn't work. So assuming the rest is good I guess we can either:
Merge as-is with the Skip
Remove the test
Forget this code and work on porting the Kestrel transport instead
I'm happy with whatever approach.

I will let @davidfowl. @pakrym comment on that.

[davidfowl]

Use a sockets client

[KodrAus]

@davidfowl Switched to socket client, which surfaced the many problems with my test. I've fixed those up.

I've made the RIO server a lot slower, but at least we know it works now.

[ahsonkhan]

@davidfowl, comments?

[KodrAus]

@davidfowl any more feedback?

[davidfowl]

Does it work now? @benaadams did you take a look?

[KodrAus]

Yep, it totally works now.

[ahsonkhan]

ping @benaadams

@davidfowl, @KodrAus, is this good to go?

[KodrAus]

@ahsonkhan It's just waiting on a review

[ahsonkhan]

@davidfowl, @benaadams - please take a look

[ahsonkhan]

@KodrAus, is this change still relevant? If so, can you please fix the merge conflict? Ty.

@davidfowl, @benaadams, @KrzysztofCwalina - are we taking this PR? If not, we should close it.

[KodrAus]

@ahsonkhan I haven't looked at this in a while. I'll take a look at the conflict, this might not be needed anymore.

[ahsonkhan]

Closing this PR. Please feel free to re-open if necessary.