This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Merge nmirror to master #4340
Merged
Merge nmirror to master #4340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial fix for https://devdiv.visualstudio.com/DevDiv/_workitems/edit/478298 Right now, this is testable through FieldInfo.SetValue(). Method invocations will still fail because the toolchain turns all pointer EETypes into "IntPtr" before we get called. Logic inspired from https://github.com/dotnet/coreclr/blob/b24d46b2fed0166cfe3bc2ae39e95b6a049f52fe/src/vm/reflectioninvocation.cpp#L227
dotnet-bot
pushed a commit
to dotnet/coreclr
that referenced
this pull request
Aug 17, 2017
Merge nmirror to master Signed-off-by: dotnet-bot <[email protected]>
jkotas
added a commit
to dotnet/coreclr
that referenced
this pull request
Aug 18, 2017
Merge nmirror to master Signed-off-by: dotnet-bot <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.