Skip to content

Fix loc import #604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BillWagner merged 1 commit into from
Dec 8, 2025
Merged

Fix loc import #604

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion DotNet.DocsTools/GitHubObjects/QuestIssue.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,9 @@ public static GraphQLPacket GetQueryPacket(QuestIssueOrPullRequestVariables vari
["questlabels"] = new string[]
{
variables.importTriggerLabelText ?? throw new ArgumentException("The import trigger label can't be null"),
variables.importedLabelText ?? throw new ArgumentException("The imported label can't be null")
variables.importedLabelText ?? throw new ArgumentException("The imported label can't be null"),
Copy link
Contributor

@gewarren gewarren Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should we use the helper ArgumentException.ThrowIfNullOrEmpty instead? (example)

Copy link
Member Author

@BillWagner BillWagner Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ordinarily, yet. But, this is in an expression context and that's a statement.

variables.removeLabelText ?? throw new ArgumentException("The remove label can't be null"),
variables.localizationLabelText ?? throw new ArgumentException("The localization label can't be null")
}
}
};
Expand Down
4 changes: 3 additions & 1 deletion actions/sequester/Quest2GitHub/QuestGitHubService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,9 @@ async Task ProcessItems(IAsyncEnumerable<QuestIssueOrPullRequest> items)
{
await foreach (QuestIssueOrPullRequest item in items)
{
if (item.Labels.Any(l => (l.Id == _importTriggerLabel?.Id) || (l.Id == _importedLabel?.Id) || (l.Id == _removeLinkedItemLabel?.Id)))
if (item.Labels.Any(l =>
(l.Id == _importTriggerLabel?.Id) || (l.Id == _importedLabel?.Id) ||
(l.Id == _removeLinkedItemLabel?.Id) || l.Id == _locItemLabel?.Id))
{
bool request = item.Labels.Any(l => l.Id == _importTriggerLabel?.Id);
bool sequestered = item.Labels.Any(l => l.Id == _importedLabel?.Id);
Expand Down
Loading