Unit testing example does not work in docker

[alexellis]

Issue Title

With this article:

https://github.com/dotnet/core-docs/blob/master/docs/core/testing/unit-testing-with-dotnet-test.md

General

I was able to set up a unit test project and have this restored/running on my Mac but when it came to using the Docker image for Preview 1 or 2 it failed.

Errors in /root/dn/test/project.json
    Unable to resolve 'RateCalc.Engine' for '.NETCoreApp,Version=v1.0'.

The code is available here:

https://github.com/alexellis/dncore-market-rates

I am a bit confused about these two lines in the unit test project:

      "imports": [
        "dotnet5.4",
        "portable-net451+win8"
      ]

The other projects created are using dncore 5.0 - does this mean we need Mono or a full .NET runtime in order to use xunit?

1. Suggest reviewers
   • If you know someone who can provide feedback, use '@' to ask them to review.

@BillWagner / @ Steve Smith

I've also provided a Dockerfile.

[BillWagner]

@alexellis Thanks for writing the issue, and providing a link to your project.

I think you are seeing the error because your tests are in the 'test' directory, and not it in a subdirectory of 'test'. Can you move that project into a sub-directory (e.g. 'test/EngineTests') and let us know if it works?

We can update the article to make that more clear.

Thanks.

[alexellis]

@BillWagner I'm afraid that didn't solve the problem. This works on my Mac, but not within Docker with either of the official images. Here are more details.

This is my resulting structure: (You can clone it and try it - if you're on Mac or Windows 10 there is a 1-click install for Docker that runs without VirtualBox)

./Dockerfile
./global.json
./LICENSE
./src
./src/RateCalc.App
./src/RateCalc.App/market.csv
./src/RateCalc.App/Program.cs
./src/RateCalc.App/project.json
./src/RateCalc.App/project.lock.json
./src/RateCalc.Engine
./src/RateCalc.Engine/CsvParser.cs
./src/RateCalc.Engine/project.json
./src/RateCalc.Engine/project.lock.json
./src/RateCalc.Engine/Rates.cs
./test
./test/RateCalc.Engine.Tests
./test/RateCalc.Engine.Tests/CsvParserTest.cs
./test/RateCalc.Engine.Tests/project.json
./test/RateCalc.Engine.Tests/project.lock.json
./test/RateCalc.Engine.Tests/Tests.cs

Same issue, works on Mac locally, but not in Docker image.

error: Unable to resolve 'RateCalc.Engine' for '.NETCoreApp,Version=v1.0'.
info : Committing restore...
log  : Writing lock file to disk. Path: /root/dn/test/RateCalc.Engine.Tests/project.lock.json
log  : /root/dn/test/RateCalc.Engine.Tests/project.json
log  : Restore failed in 7406ms.

Errors in /root/dn/test/RateCalc.Engine.Tests/project.json
    Unable to resolve 'RateCalc.Engine' for '.NETCoreApp,Version=v1.0'.

NuGet Config files used:
    /root/.nuget/NuGet/NuGet.Config

Feeds used:
    https://api.nuget.org/v3/index.json

Installed:
    124 package(s) to /root/dn/test/RateCalc.Engine.Tests/project.json
The command '/bin/sh -c dotnet restore' returned a non-zero code: 1

Whatever was installed on my Mac

dotnet --info
.NET Command Line Tools (1.0.0-preview2-003121)

Product Information:
 Version:            1.0.0-preview2-003121
 Commit SHA-1 hash:  1e9d529bc5

Runtime Environment:
 OS Name:     Mac OS X
 OS Version:  10.11
 OS Platform: Darwin
 RID:         osx.10.11-x64

Preview 1 on Docker:

dotnet --info
.NET Command Line Tools (1.0.0-preview1-002702)

Product Information:
 Version:     1.0.0-preview1-002702
 Commit Sha:  6cde21225e

Runtime Environment:
 OS Name:     debian
 OS Version:  8
 OS Platform: Linux
 RID:         debian.8-x64

Preview 2 on Docker

docker run microsoft/dotnet:latest dotnet --info
.NET Command Line Tools (1.0.0-preview1-002702)

Product Information:
 Version:     1.0.0-preview1-002702
 Commit Sha:  6cde21225e

Runtime Environment:
 OS Name:     debian
 OS Version:  8
 OS Platform: Linux
 RID:         debian.8-x64

What is interesting is that the RateCalc.App application compiles without warnings.

Can you also speak to the odd part of the project.json file.. ?

      "imports": [
        "dotnet5.4",
        "portable-net451+win8"
      ]

[BillWagner]

Thanks for doing that research. Let me do a bit of research, and I'll get back to you.

[blackdwarf]

@alexellis in your Dockerfile, could you test out what happens when you change the WORKDIR to point to the root folder, where the global.json is and not to the actual test folder?

Actually, come to think of it, you could run dotnet restore in the solution folder first and then just WORKDIR into other folders and do dotnet build.

[jeremymeng]

I think @alexellis is missing the global.json in the Docker image. See devlooped/moq#168 (comment).

[blackdwarf]

@jeremymeng the Dockerfile in the repo shows that global.json is being added.

[alexellis]

It is now working inside Docker, but does a complete restore every build. Is there a way of changing the instruction order to take advantage of the step caching?

I.e. in nodejs with npm you can restore before adding any code.

[mairaw]

@blackdwarf @jeremymeng can you help with @alexellis's last question?

[jeremymeng]

@glennc might have some ideas for this scenario (dotnet restore caching in Docker).

[mairaw]

@spboyer can you take a look at this one?

[spboyer]

@alexellis when you say that it is doing the restore every time, you are stating that each time you build the image?

The microsoft/dotnet:1.0.0-preview2-sdk image pre-loads the Nuget cache in the base image. When you see Step 8 in the output

Step 8 : RUN dotnet restore
 ---> Running in 8a3175ee5bf2
log  : Restoring packages for /root/dn/test/RateCalc.Engine.Tests/project.json...
log  : Restoring packages for /root/dn/src/RateCalc.App/project.json...
log  : Restoring packages for /root/dn/src/RateCalc.Engine/project.json...
log  : Writing lock file to disk. Path: /root/dn/src/RateCalc.Engine/project.lock.json
log  : Writing lock file to disk. Path: /root/dn/src/RateCalc.App/project.lock.json
log  : /root/dn/src/RateCalc.Engine/project.json
log  : Restore completed in 1053ms.
log  : /root/dn/src/RateCalc.App/project.json
log  : Restore completed in 1054ms.
log  : Installing System.Threading.Overlapped 4.0.1-rc2-24027.
log  : Installing System.IO.FileSystem.Watcher 4.0.0-rc2-24027.
log  : Installing System.Security.Cryptography.Csp 4.0.0-rc2-24027.
log  : Installing System.Security.Cryptography.Cng 4.1.0-rc2-24027.
.
.
.

the build is not downloading these files from Nuget, but copying them from the local cache that exists within the image. Within your Dockerfile, you are adding the application files to the image each time it is built.

ADD ./src ./src
ADD ./test ./test

In my test, I never called dotnet restore on my local machine which means that the needed assets would not exists in the ./src or ./test directories and thus needing and Installation when dotnet restore is called.

Given the amount of time to run this, Time elapsed 00:00:01.1501594; I would say that the cache being used within the Docker image is acceptable given the scenario of not ever having the dotnet resources on the local machine.

The alternative way to accomplish this would be to run the restore locally and use microsoft/dotnet:latest as the base image within your Dockerfile. This change would also require you to run dotnet publish and copy only the compiled resource to the image.

cc:/ @glennc @SteveLasker

[alexellis]

I'm sure it was not taking 1 second (a lot longer). Let me try to reproduce the issue - I guess this was raised 3 months ago maybe things have changed.