Skip to content

Expand compatibility descriptions #25360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 28, 2021
Merged

Expand compatibility descriptions #25360

merged 2 commits into from
Jul 28, 2021

Conversation

gewarren
Copy link
Contributor

Based on discussion with Mark Miller and Priya.

@gewarren gewarren requested a review from a team as a code owner July 27, 2021 18:13
@dotnet-bot dotnet-bot added this to the July 2021 milestone Jul 27, 2021
@PriyaPurkayastha
Copy link

cc @marklio

Copy link

@marklio marklio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of tweaks to the wording that make things a little more clear to me in this context. It feels like we should have a larger document with more complete definitions, and some examples. I'm requesting changes because the proposed wording seems to indicate that breaks are guaranteed. We rarely break things in this way. Typically, there is only a narrow breaking scenario.

@gewarren gewarren requested a review from marklio July 28, 2021 18:04
Copy link

@marklio marklio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a big improvement from a content perspective. I'm not entirely familiar with the template process to know whether this would be a breaking change to the template (would it make new issues different from existing ones and make it hard to to machine categorization, etc.)

@gewarren
Copy link
Contributor Author

I think this is a big improvement from a content perspective. I'm not entirely familiar with the template process to know whether this would be a breaking change to the template (would it make new issues different from existing ones and make it hard to to machine categorization, etc.)

Thanks. We only just added these compatibility types, so I don't think any issues are actually labeled accordingly yet. A good time to make it right.

@gewarren gewarren merged commit a7a683d into main Jul 28, 2021
@gewarren gewarren deleted the gewarren-patch-1 branch July 28, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants