-
Notifications
You must be signed in to change notification settings - Fork 6k
Expand compatibility descriptions #25360
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @marklio |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of tweaks to the wording that make things a little more clear to me in this context. It feels like we should have a larger document with more complete definitions, and some examples. I'm requesting changes because the proposed wording seems to indicate that breaks are guaranteed. We rarely break things in this way. Typically, there is only a narrow breaking scenario.
Co-authored-by: Mark Miller <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a big improvement from a content perspective. I'm not entirely familiar with the template process to know whether this would be a breaking change to the template (would it make new issues different from existing ones and make it hard to to machine categorization, etc.)
Thanks. We only just added these compatibility types, so I don't think any issues are actually labeled accordingly yet. A good time to make it right. |
Based on discussion with Mark Miller and Priya.