Skip to content

Ping breaking change #28788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2022
Merged

Ping breaking change #28788

merged 2 commits into from
Mar 24, 2022

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Mar 24, 2022 •
edited
Loading

@gewarren gewarren requested review from rzikm and a team March 24, 2022 02:51
BillWagner
BillWagner approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. You can :shipit: when you're ready.

rzikm
rzikm approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@rzikm rzikm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gewarren gewarren merged commit 4ae1f70 into dotnet:main Mar 24, 2022
@gewarren gewarren deleted the ping-payload branch March 24, 2022 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@rzikm rzikm rzikm approved these changes

Assignees
No one assigned
Labels
dotnet-fundamentals/svc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Breaking change]: PlatformNotSupportedException on non-privileged Linux processes when custom payload is specified to Ping
4 participants
@gewarren @BillWagner @rzikm @dotnet-bot