Skip to content

Backslash mapping breaking change #33790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2023
Merged

Backslash mapping breaking change #33790

merged 2 commits into from
Jan 31, 2023

Conversation

gewarren
Copy link
Contributor

@gewarren gewarren commented Jan 31, 2023 •
edited
Loading

Fixes #32906

Preview

@dotnet-bot dotnet-bot added this to the January 2023 milestone Jan 31, 2023
@ghost ghost added the 🏁 Release: .NET 8 Work items for the .NET 8 release label Jan 31, 2023
@gewarren gewarren requested review from janvorli and a team January 31, 2023 02:16
BillWagner
BillWagner approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @gewarren

Let's :shipit:

janvorli
janvorli approved these changes Jan 31, 2023
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@gewarren gewarren merged commit 10c6477 into dotnet:main Jan 31, 2023
@gewarren gewarren deleted the backslash-conversion branch January 31, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

@janvorli janvorli janvorli approved these changes

Assignees
No one assigned
Labels
🏁 Release: .NET 8 Work items for the .NET 8 release dotnet-fundamentals/svc
Projects
None yet
Milestone
January 2023
Development

Successfully merging this pull request may close these issues.

[Breaking change]: Remove file path backslash to slash mapping in CoreCLR native runtime and PAL on Unix
4 participants
@gewarren @BillWagner @janvorli @dotnet-bot