Skip to content

JSON Polymorphic Serialization - Contract model example is incorrect #45873

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kezenator
Copy link

@kezenator kezenator commented Apr 21, 2025

Summary

Fixed C# example to match VB example

Fixes #45871


Internal previews

📄 File 🔗 Preview link
docs/standard/serialization/system-text-json/polymorphism.md docs/standard/serialization/system-text-json/polymorphism

@kezenator kezenator requested review from gewarren and a team as code owners April 21, 2025 12:18
@dotnetrepoman dotnetrepoman bot added this to the April 2025 milestone Apr 21, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Apr 21, 2025
@kezenator kezenator changed the title Fixes #45871 JSON Polymorphic Serialization - Contract model example is incorrect Apr 21, 2025
@gewarren
Copy link
Contributor

The example is correct as written, although perhaps slightly confusing. Please see explanation in #45871 (comment).

@gewarren gewarren closed this Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contract model example is incorrect - Field DerivedTypes cannot be set
2 participants